Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @timwright12, @mapk, @sarahmonster. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
left a comment
There was a problem hiding this comment.
I tested and it's working well.
- pullquote is not available in the inserter or slash command
- existing pullquote blocks work as before
- global styles for pullquote are all good
- pullquote > quote transforms work as expected
Thanks for picking this task up!
| Before | After |
|---|---|
![]() |
![]() |
| Before | After |
|---|---|
![]() |
![]() |
I found another ref to core/pullquote in the rich text transforms in
packages/block-library/src/utils/transformation-categories.native.js
Should that be removed as well?
|
@ramonjd Good catch. I have removed it in the last commit. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
It looks good overall, but if we want to completely deprecate it, we may also be able to address the following points:
Replace blocks in the demo content:
Lines 176 to 178 in e5e95ff
Remove Pullquote from the document or replace it with Quote
Remove Pullquote from the native app transformation menu:
Replace core/pullquote with core/quote in the List View e2e test:
Replace with Quote block in StyleBook overview screen
gutenberg/packages/edit-site/src/components/style-book/examples.tsx
Lines 171 to 177 in e5e95ff
|
Note: We are almost ready to ship this PR, but given the impact on default themes and theme developers, let's punt this to the 7.0 cycle. See WordPress/wordpress-develop#10202 (comment) |
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
Important
This PR is planned to ship in WordPress 7.0. Therefore, this PR can not be included in Gutenberg 21.9, because if it were included in Gutenberg 21.9, it would ship in WordPress 7.0. We will merge this PR after Gutenberg 21.9 is released.
|
Retested. Bye bye, pull quote! Thanks for all the work on this @Utsav-Ladani |
|
I've merged the latest trunk into this branch, but somehow the conflict message doesn't disappear, and CIs don't start. I plan to submit a new PR based on this branch. |
|
I submitted a new PR based on this branch: #73228 |




What?
Closes #11610
Deprecating the
Pullquoteblock and recommending the use of theQuoteblock instead.Why?
Purpose of
PullquoteandQuoteis almost identical, butQuoteis using<blockquote>tag which is semantically more correct compared toPullquotewhich uses<figure>See #11610 for more details.
How?
Pullquoteblock to indicate that it’s deprecated and suggest using theQuoteblock instead.Pullquoteblock.Testing
Pullquoteblocks should work without any issues.Pullquoteblock should not be available in the inserter or should not be added inline using the/pullquotecommand.Pullquoteblock.