-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Link Control: Update button text from Save to Apply #72005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +3 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Especially as it's good to avoid the x2 Save in the same view.
I tested creating a link and you never see the button during that process so this seems good.
PS: you will need to update the tests :)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 88ace76. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18167152252
|
What?
Changes the copy of the "Save" button in Link UI to "Apply"
Why?
We have two different "Save" buttons on the screen. The Link UI button doesn't actually save the change to the database, it simply updates the setting in the client. Users might think that the "Save" button will persist their change, which it does not. By changing the copy to "Apply" users are more likely to remember that they also need to "Save" the change.
How?
Text change
Testing Instructions
Screenshots or screencast