Fix incorrect block editing mode assigned in some cases #71970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -10 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in baaa9bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18125814396
|
Member
|
LGTM TrunkKapture.2025-10-01.at.13.14.41.mp4This PRKapture.2025-10-01.at.13.16.07.mp4 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Oct 1, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
assigned in some cases
This fixes the zoom in > zoom out case.
Were there any others?
tellthemachines
approved these changes
Oct 1, 2025
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this! LGTM.
Contributor
Author
That's the only one I know! Thanks for the reviews 😄 |
talldan
deleted the
fix/incorrect-block-editing-mode-for-zoomed-out-inserted-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71908
How?
The bug occurred due to an optimization that was added. It assumed that if we'd just assigned a
disabledmode to a parent, thedisabledmode should automatically cascade and the child should also bedisabled. However, that was incorrect, incontentOnlymode we often want adisabledparent to have acontentOnlychild, the optimization was not allowing this.Testing Instructions
Expected: You should be able to select the content in the pattern
In trunk: You can't select the content in the pattern