WIP: Block Comments: Split 'isSelected' and 'isExpanded' states #71969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -60 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
[Feature] Notes
Mamaduka
force-pushed
the
try/block-comments-expanded-state
branch
from
1e6a0a4 to
a080c0d
Compare
Mamaduka
added
[Type] Code Quality
Mamaduka
force-pushed
the
try/block-comments-expanded-state
branch
from
a080c0d to
51cda26
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Requires #71962.
Based on #71898 (review)
PR refactors how the
Threadcomponent handles selected and expanded states. Now they're controlled by two separate values:isSelectedis derived from the current block selection.isExpandedis now a local state of theThreadcomponent.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast