-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Comment: Improve comment thread outline #71961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +30 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @t-hamano!
|
Flaky tests detected in 096ffc5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18115657214
|
What?
This PR will apply the correct style based on the design, depending on the state of the comment thread.
How?
At the same time, this PR avoided hard-coded values and used SCSS variables.
Testing Instructions
Click on the block, click on the comment, or focus on the comment with your keyboard to see the outline.
Screenshots or screencast
Note that in the following screenshots and screencast, the focus outline width is 2px, as my laptop doesn't have a high-resolution screen. If you're using a Retina Mac, the outline width should probably be 1.5px.
576d8110a022d292ad05ba83b2e621be.mp4