Block Comments: Simplify action callbacks #71892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -41 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
Member
Author
|
I've a follow-up refactoring, but it touches more components, so it might be better to land separately and avoid more merge conflicts. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Sep 25, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Nice refactoring! Happy to see a lot of red lines.
t-hamano
approved these changes
Sep 25, 2025
Member
Author
|
Thanks for the review, @t-hamano! |
Mamaduka
force-pushed
the
optimize/block-comment-actions
branch
from
6975e61 to
45b5bd5
Compare
t-hamano
added
[Feature] Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #66377.
PR makes the following modifications for block comments' CRUD callbacks:
onEditCommentfor anything comment editing related. Remove separate callbacks for status changes.onCommentDelete. There's no need to re-select data from the store; it can access the whole comment object.addNewComment. We can use selectors inside similar callbacks.PR also includes additions and improvements for e2e tests.
Testing Instructions
All modifications in question have e2e test coverage.
Testing Instructions for Keyboard
Same.