Skip to content

Block Comments: Make comment thread focusable and improve keyboard navigation #71883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 29, 2025
Merged

Block Comments: Make comment thread focusable and improve keyboard navigation #71883

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e8faa2f
Block Comments: Make commment thread focusable
t-hamano Sep 24, 2025
fd6e6b9
Resolve conflicts
t-hamano Sep 25, 2025
04cce97
Restore thread id attirbute
t-hamano Sep 25, 2025
d04a8d0
Remove event.stopPropagation
t-hamano Sep 25, 2025
f130726
Resolve conflicts
t-hamano Sep 26, 2025
dcef25a
Close focused thread by enter key
t-hamano Sep 26, 2025
be7792e
Close focused thread by esc key
t-hamano Sep 26, 2025
f4f20e3
Focus current thread when the thread is resolved
t-hamano Sep 26, 2025
0bddef3
Add thread comment as aria-label
t-hamano Sep 26, 2025
a452405
Add aria-label
t-hamano Sep 26, 2025
8b91945
Merge branch 'trunk' into block-comment-focusable-thread
t-hamano Sep 26, 2025
849df9c
Fix e2e test
t-hamano Sep 26, 2025
ebfc1df
Improve aria-label
t-hamano Sep 26, 2025
e7b464e
Merge branch 'trunk' into block-comment-focusable-thread
t-hamano Sep 27, 2025
6b99421
Use comment excerpt for aria-label
t-hamano Sep 27, 2025
550e582
Add "Comment: " prefix to comment aria label
t-hamano Sep 29, 2025
d200041
Merge branch 'trunk' into block-comment-focusable-thread
t-hamano Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix e2e test
  • Loading branch information
@t-hamano
t-hamano committed Sep 26, 2025
commit 849df9c49564a8f964127b81c0748638956de2b4
1 change: 1 addition & 0 deletions test/e2e/specs/editor/various/block-comments.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ test.describe( 'Block Comments', () => {
.filter( { hasText: 'Comment marked as resolved.' } )
).toBeVisible();

await page.locator( '.editor-collab-sidebar-panel__thread' ).click();
const commentForm = page.getByRole( 'textbox', { name: 'Comment' } );
await commentForm.fill( 'Test reply that reopens the comment.' );
await page
Expand Down
Loading