Skip to content

Block Comments: Improve input labels #71843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 26, 2025
Merged

Block Comments: Improve input labels #71843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2b57bff
Improve comment input labels
karthick-murugan Sep 23, 2025
8abb312
Removed return to block function
karthick-murugan Sep 23, 2025
d227fd4
Feedback Changes
karthick-murugan Sep 25, 2025
eef4def
Merge branch 'trunk' into improve-comment-input-labels
karthick-murugan Sep 25, 2025
bfc8c14
Removed few unwanted periods
karthick-murugan Sep 25, 2025
97615a9
Updated the feedback
karthick-murugan Sep 25, 2025
7fa4066
JS Lint fixes
karthick-murugan Sep 25, 2025
0f35cd0
Feedback changes
karthick-murugan Sep 25, 2025
3099d32
Merge branch 'trunk' of github.com:karthick-murugan/gutenberg into im…
karthick-murugan Sep 26, 2025
a0c530e
Merge branch 'trunk' into improve-comment-input-labels
karthick-murugan Sep 26, 2025
9dcf9c3
Js Lint errors
karthick-murugan Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Feedback changes
  • Loading branch information
@karthick-murugan
karthick-murugan committed Sep 25, 2025
commit 0f35cd01c2a16531f8adca7c9e1e30a5dc269f29
4 changes: 3 additions & 1 deletion packages/editor/src/components/collab-sidebar/comment-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { sanitizeCommentString } from './utils';
* @param {Object} props.thread - The comment thread object.
* @param {string} props.submitButtonText - The text to display on the submit button.
* @param {string?} props.placeholderText - The placeholder text for the comment input.
* @param {string?} props.labelText - The label text for the comment input.
* @param {number?} props.rows - The number of rows for the comment input.
* @return {React.ReactNode} The CommentForm component.
*/
Expand All @@ -38,6 +39,7 @@ function CommentForm( {
thread,
submitButtonText,
placeholderText,
labelText,
rows = 4,
} ) {
const [ inputComment, setInputComment ] = useState(
Expand All @@ -49,7 +51,7 @@ function CommentForm( {
return (
<>
<VisuallyHidden as="label" htmlFor={ inputId }>
{ __( 'Comment' ) }
{ labelText ?? __( 'Comment' ) }
</VisuallyHidden>
<TextareaAutosize
id={ inputId }
Expand Down
36 changes: 0 additions & 36 deletions packages/editor/src/components/collab-sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,42 +43,6 @@
}
}

.editor-collab-sidebar-panel__comment-label {
font-size: 13px;
font-weight: 500;
color: $gray-700;
margin-bottom: $grid-unit-10;
display: block;
// Screen reader only by default
position: absolute;
left: -10000px;
top: auto;
width: 1px;
height: 1px;
overflow: hidden;
// Visible when explicitly shown
&.is-visible {
position: static;
left: auto;
top: auto;
width: auto;
height: auto;
overflow: visible;
}
}

.editor-collab-sidebar-panel__comments-list {
list-style: none;
margin: 0;
padding: 0;
li {
margin-bottom: $grid-unit-20;
&:last-child {
margin-bottom: 0;
}
}
}

.editor-collab-sidebar-panel__child-thread {
margin-top: 15px;
}
Expand Down
Loading