-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Time To Read: Make display as range the default, and allow older blocks to migrate to this setting #71842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ks to migrate to this setting
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change! I think that's the best approach to move forward and existing blocks changing to display a range now, is actually an improvement.
|
Size Change: -117 B (-0.01%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @scruffian!
|
Flaky tests detected in 89bf9cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17945521925
|
What?
Makes "Display as range" the default setting for the Time To Read block, and removes code that sets this to true for new blocks.
Note that this means that existing blocks will change to display a range now.
Why?
The code is cleaner and simpler, and the defaults for the block more accurately represent the behaviour of the block.
How?
Removes the code that sets "displayAsRange" to true on insertion and just sets that as true for the block.
Testing Instructions