-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Export DataViewsPicker from dataviews package #71836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andrewserong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll need a one-liner changelog entry, but thanks for adding this!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Do you reckon? The changelog that mentions the new component should cover this (I guess technically that changelog entry should have been for this PR). I also think we should probably try to get this into 21.7 cc @ellatrix Edit: actually we probs don't need it in the plugin because it's not being used anywhere yet. |
|
Flaky tests detected in 13b4820. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17938052999
|
Yes, sorry I should have clarified, just adding a reference to this PR is fine like you've done here 👍 |
What?
Quick follow-up to #70971 - just exporting the new component from the package index!