Block Commenting: Don't show unpinnable sidebar on mobile viewports #71834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: +10 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kunalpuri123. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
Mamaduka
approved these changes
Sep 23, 2025
Member
|
Nice work! |
Contributor
Author
|
Thanks for the review! |
t-hamano
added
[Feature] Notes
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the issue of not being able to edit content on the mobile viewport by not rendering the unpinnable sidebar on the mobile viewport.
Closes #71718
Why?
There are two types of sidebars.
Pinnable Sidebar
It can be accessed from the block toolbar or the comments button in the header. This sidebar has a close button.
Unpinnable Sidebar
Shown by default when the Post Sidebar is hidden. This sidebar doesn't have a close button:
The fundamental problem is that this unpinnable sidebar takes up the entire screen in mobile layouts and cannot be closed.
How?
Don't show the unpinnable sidebar on mobile viewports. Even without the unpinnable sidebar, there is still a way to access the comments sidebar from the mobile layout by clicking the Comment button on the block toolbar.
Testing Instructions
Narrow your browser and make sure you can always access the comments.
Screenshots or screencast
bc58c6076fee9635558f5220bab46b0f.mp4