Skip to content

Block Bindings: Fix pattern override bug, editing was allowed on non enabled overrides blocks. #71813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2025
Merged

Block Bindings: Fix pattern override bug, editing was allowed on non enabled overrides blocks. #71813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b6e8f8
Fix pattern override bug, first attempt
cbravobernal Sep 22, 2025
2cf9f5b
Fix richtext basically not working
cbravobernal Sep 22, 2025
d976bd2
Add e2e test
cbravobernal Sep 22, 2025
7d1a3ba
Update test
cbravobernal Sep 22, 2025
1b9cffb
Update the test to edit the link
cbravobernal Sep 23, 2025
4cfc67d
Updated wrong key
cbravobernal Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/block-editor/src/components/rich-text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,15 @@ export function RichTextWrapper(
blockContext,
]
);
const isInsidePatternOverrides = !! blockContext?.[ 'pattern/overrides' ];
const hasOverrideEnabled =
blockBindings?.__default?.source === 'core/pattern-overrides';

const shouldDisableEditing = readOnly || disableBoundBlock;
const shouldDisableForPattern =
isInsidePatternOverrides && ! hasOverrideEnabled;

const shouldDisableEditing =
readOnly || disableBoundBlock || shouldDisableForPattern;

const { getSelectionStart, getSelectionEnd, getBlockRootClientId } =
useSelect( blockEditorStore );
Expand Down
94 changes: 94 additions & 0 deletions test/e2e/specs/editor/various/pattern-overrides.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ test.describe( 'Pattern Overrides', () => {
test.beforeAll( async ( { requestUtils } ) => {
await Promise.all( [
requestUtils.activateTheme( 'emptytheme' ),
await requestUtils.activatePlugin(
'gutenberg-test-block-bindings'
),
requestUtils.deleteAllBlocks(),
] );
} );
Expand All @@ -24,6 +27,7 @@ test.describe( 'Pattern Overrides', () => {
test.afterAll( async ( { requestUtils } ) => {
await Promise.all( [
requestUtils.activateTheme( 'twentytwentyone' ),
requestUtils.deactivatePlugin( 'gutenberg-test-block-bindings' ),
] );
} );

Expand Down Expand Up @@ -789,6 +793,96 @@ test.describe( 'Pattern Overrides', () => {
await expect( buttonLink ).toHaveAttribute( 'rel', /^\s*nofollow\s*$/ );
} );

test( 'should disable editing for pattern blocks without overrides enabled, even when mixed with bound attributes', async ( {
page,
admin,
requestUtils,
editor,
} ) => {
const { id } = await requestUtils.createBlock( {
title: 'Pattern',
content: `<!-- wp:paragraph {"metadata":{"name":"Post Meta Binding","bindings":{"__default":{"source":"core/pattern-overrides"}}}} -->
<p>Edit me</p>
<!-- /wp:paragraph -->
<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button {"metadata":{"name":"Read Only Button","bindings":{"url":{"source":"core/post-meta","args":{"key":"text_custom_field"}}}}} -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button">Read Only Button Text</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->`,
status: 'publish',
} );

await admin.createNewPost();
await editor.insertBlock( {
name: 'core/block',
attributes: { ref: id },
} );

const patternBlock = editor.canvas.getByRole( 'document', {
name: 'Block: Pattern',
} );

await expect( patternBlock.getByText( 'Edit me' ) ).toBeVisible();
await expect(
patternBlock.getByText( 'Read Only Button Text' )
).toBeVisible();

const editableParagraph = patternBlock
.getByRole( 'document', {
name: 'Block: Paragraph',
includeHidden: true,
} )
.filter( { hasText: 'Edit me' } );
const nonEditableButton = patternBlock
.getByRole( 'document', {
name: 'Block: Button',
exact: true,
includeHidden: true,
} )
.filter( { hasText: 'Read Only Button Text' } );

await editableParagraph.click();
await editableParagraph.focus();
await page.keyboard.type( ' - Edited' );
await expect( editableParagraph ).toHaveText( 'Edit me - Edited' );

// Button with only URL binding (no pattern overrides) should not have editable text.
await nonEditableButton.click();
const initialText = await nonEditableButton.textContent();
await page.keyboard.type( 'Edited' );
const finalText = await nonEditableButton.textContent();
expect( initialText ).toBe( finalText );

await nonEditableButton.click();
await editor.showBlockToolbar();

// Open the link control
const linkButton = page.getByRole( 'button', {
name: 'Link',
exact: true,
} );
await linkButton.click();

const urlInput = page.getByPlaceholder( 'Search or type URL' );
await urlInput.fill( '#test' );

// Save the link
const saveLinkButton = page.locator(
'.block-editor-link-control__search-submit'
);
await saveLinkButton.click();

// Publish the post
const postId = await editor.publishPost();

// Check on the frontend that the URL was updated
await page.goto( `/?p=${ postId }` );
const frontendButton = page.getByRole( 'link', {
name: 'Button Text',
} );
await expect( frontendButton ).toHaveAttribute( 'href', '#test' );
} );

test( 'resets overrides after clicking the reset button', async ( {
page,
admin,
Expand Down
Loading