Skip to content

Block Bindings: Fix pattern override bug, editing was allowed on non enabled overrides blocks. #71813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2025
Merged

Block Bindings: Fix pattern override bug, editing was allowed on non enabled overrides blocks. #71813

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b6e8f8
Fix pattern override bug, first attempt
cbravobernal Sep 22, 2025
2cf9f5b
Fix richtext basically not working
cbravobernal Sep 22, 2025
d976bd2
Add e2e test
cbravobernal Sep 22, 2025
7d1a3ba
Update test
cbravobernal Sep 22, 2025
1b9cffb
Update the test to edit the link
cbravobernal Sep 23, 2025
4cfc67d
Updated wrong key
cbravobernal Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix pattern override bug, first attempt
  • Loading branch information
@cbravobernal
cbravobernal committed Sep 22, 2025
commit 3b6e8f894e46ea6f1803f60ce38ce42d99627276
6 changes: 4 additions & 2 deletions packages/block-editor/src/components/rich-text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,11 @@ export function RichTextWrapper(
blockContext,
]
);
const arePatternOverridesEnabled =
blockBindings?.__default?.source === 'core/pattern-overrides';

const shouldDisableEditing = readOnly || disableBoundBlock;

const shouldDisableEditing =
readOnly || disableBoundBlock || ! arePatternOverridesEnabled;
const { getSelectionStart, getSelectionEnd, getBlockRootClientId } =
useSelect( blockEditorStore );
const { selectionChange } = useDispatch( blockEditorStore );
Expand Down