Block Bindings: Fix pattern override bug, editing was allowed on non enabled overrides blocks. #71813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Feature] Block bindings
[Type] Bug
|
Size Change: +41 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
cbravobernal
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
force-pushed
the
fix/pattern-bound-attributes-should-not-edit
branch
from
d558ee3 to
d976bd2
Compare
talldan
reviewed
Sep 23, 2025
Member
|
Everything is working correctly now 💯 In the future, we could also look at how to deal with the placeholder for the button's text that is readonly in this case so 
|
gziolo
reviewed
Sep 23, 2025
Member
|
Test pattern that I used: <!-- wp:paragraph {"metadata":{"name":"Post Meta Binding","bindings":{"content":{"source":"testing/complete-source","args":{"key":"text_field"}},"__default":{"source":"core/pattern-overrides"}}}} -->
<p>Post Meta Binding</p>
<!-- /wp:paragraph -->
<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button {"metadata":{"name":"Read Only Button","bindings":{"url":{"source":"core/post-meta","args":{"key":"url_custom_field"}},"__default":{"source":"core/pattern-overrides"}}}} -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button"></a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->Screencast confirming that editing both overrides and other sources used with a single block works perfectly fine: Screen.Recording.2025-09-23.at.11.39.17.movEdit: Pleas ignore the misleading names in the UI that I noticed after watching it here 😄 |
gziolo
approved these changes
Sep 23, 2025
cbravobernal
added
the
Backport to Gutenberg RC
|
Flaky tests detected in 4cfc67d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17943715486
|
cbravobernal
deleted the
fix/pattern-bound-attributes-should-not-edit
branch
ellatrix
pushed a commit
that referenced
this pull request
Sep 24, 2025
…enabled overrides blocks. (#71813) * Fix pattern override bug, first attempt * Fix richtext basically not working * Add e2e test * Update test * Update the test to edit the link Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
ellatrix
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71768
Why?
Explained in #71768. Quick summary:
If you have a pattern override, with one block with overrides enabled, and the other one with overrides disabled. If this second one has any bound attribute, it becomes editable when it should not.
How?
Make an additional check on richtext that contains
__defaultattribute that makes the block override enabled.Testing Instructions
The issue has a more detailed explanation about how to debug it. There is also a new e2e.