Skip to content

i18n: show "1 more reply" instead of "1 more replies" in block comments #71685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

i18n: show "1 more reply" instead of "1 more replies" in block comments #71685

merged 1 commit into from
Sep 16, 2025

Conversation

@R1shabh-Gupta
Copy link
Contributor

@R1shabh-Gupta R1shabh-Gupta commented Sep 16, 2025 •
edited
Loading

What?

Closes #71684

Fixes the grammatical error in block commenting where "1 more replies" was displayed instead of the correct singular form "1 more reply".

Why?

When there is exactly one hidden reply in a comment thread, the interface incorrectly shows "1 more replies" which is grammatically wrong. It should show "1 more reply" (singular) for one reply and "X more replies" (plural) for multiple replies. This improves the user experience and ensures proper grammar across all languages that support WordPress pluralization.

How?

  • Replaced _x() function with _n() function in the comments component
  • Added proper singular and plural forms: '%s more reply' and '%s more replies'

Testing Instructions

  1. Open the WordPress editor (post or page)
  2. Add a block (any block type works)
  3. Add at least 2 comments to the block
  4. Verify that when there's exactly 1 hidden reply, it shows "1 more reply"
  5. Verify that when there are 2 or more hidden replies, it shows "X more replies"

Screenshots or screencast

Before After
Screenshot 2025-09-16 at 10 04 00 AM Screenshot 2025-09-16 at 10 03 30 AM

@R1shabh-Gupta R1shabh-Gupta changed the title i18n: fix "more replies" pluralization in block comments i18n: show "1 more reply" instead of "1 more replies" in block comments Sep 16, 2025
@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review September 16, 2025 04:37
@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Sep 16, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Sep 16, 2025

I just merged #71387.

@R1shabh-Gupta, could you please rebase this branch on top of the trunk? The text is now placed inside a Button component, so it would be great if you could test it again just to be sure.

@R1shabh-Gupta R1shabh-Gupta force-pushed the fix/71684-comments-pluralization branch from 4b327ca to 560786e Compare September 16, 2025 08:11
@R1shabh-Gupta
Copy link
Contributor Author

R1shabh-Gupta commented Sep 16, 2025

Hey @t-hamano,
I’ve rebased the branch and tested it with the updated Button component. Everything is working as expected. ✅
Screenshot 2025-09-16 at 1 44 27 PM

t-hamano
t-hamano approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano merged commit 9509a6b into WordPress:trunk Sep 16, 2025
68 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 16, 2025
@t-hamano t-hamano added [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting and removed Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 4, 2025
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramonjd ramonjd ramonjd left review comments

@t-hamano t-hamano t-hamano approved these changes

Assignees

No one assigned

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 21.7

Development

Successfully merging this pull request may close these issues.

Block commenting: "1 more replies" should be "1 more reply"

4 participants

@R1shabh-Gupta @t-hamano @ramonjd @Mamaduka