Skip to content

Block Commenting: Add block-comments as a new post type support #71682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2025
+63 −3
Merged

Block Commenting: Add block-comments as a new post type support #71682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42bd1d9
Block Commenting: Add block-comments as a new post type support
t-hamano Sep 16, 2025
9d07a6b
Remove `function_exists` check
t-hamano Sep 16, 2025
543ab97
Make block-comments part of editor support
t-hamano Sep 16, 2025
f64cfef
REST API: Add post type support check
t-hamano Sep 16, 2025
42025a0
Merge sub-properties
t-hamano Sep 19, 2025
683bdf1
Merge branch 'trunk' into block-commenting-post-type-support
t-hamano Sep 20, 2025
0bbfecd
Use PostTypeSupportCheck
t-hamano Sep 20, 2025
ee85fcd
Restore postId check conditional statement
t-hamano Sep 20, 2025
945523a
Update packages/editor/src/components/collab-sidebar/index.js
t-hamano Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Block Commenting: Add block-comments as a new post type support
  • Loading branch information
@t-hamano
t-hamano committed Sep 16, 2025
commit 42bd1d978c462f1969cd2499773daf6b03983a52
14 changes: 14 additions & 0 deletions lib/experimental/block-comments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
<?php

/**
* Adds support for block comments to the built-in post types.
*
* @return void
*/
if ( ! function_exists( 'gutenberg_block_comment_add_post_type_support' ) ) {
function gutenberg_block_comment_add_post_type_support() {
add_post_type_support( 'post', 'block-comments' );
add_post_type_support( 'page', 'block-comments' );
}
add_action( 'init', 'gutenberg_block_comment_add_post_type_support' );
}

/**
* Updates the comment type in the REST API.
*
Expand Down
5 changes: 0 additions & 5 deletions packages/editor/src/components/collab-sidebar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,6 @@ export default function CollabSidebar() {
? resultComments.find( ( thread ) => thread.id === blockCommentId )
: null;

// If postId is not a valid number, do not render the comment sidebar.
if ( ! ( !! postId && typeof postId === 'number' ) ) {
return null;
}

return (
<>
<AddCommentComponent
Expand Down
5 changes: 4 additions & 1 deletion packages/editor/src/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import MoreMenu from '../more-menu';
import PostPreviewButton from '../post-preview-button';
import PostPublishButtonOrToggle from '../post-publish-button/post-publish-button-or-toggle';
import PostSavedState from '../post-saved-state';
import PostTypeSupportCheck from '../post-type-support-check';
import PostViewLink from '../post-view-link';
import PreviewDropdown from '../preview-dropdown';
import ZoomOutToggle from '../zoom-out-toggle';
Expand Down Expand Up @@ -197,7 +198,9 @@ function Header( {
) }

{ isBlockCommentExperimentEnabled ? (
<CollabSidebar />
<PostTypeSupportCheck supportKeys="block-comments">
<CollabSidebar />
</PostTypeSupportCheck>
) : undefined }

{ customSaveButton }
Expand Down
Loading