Skip to content

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Sep 15, 2025

What?

Move the block_bindings_supported_attributes_core/post-date that was added in #71389 to add Block Bindings support for the Date block's datetime attribute out of the Date block code and into Gutenberg's WP 6.8 compatibility layer code.

Why?

See related discussion here.

Testing Instructions

Refer to #70585.

@ockham ockham self-assigned this Sep 15, 2025
@ockham ockham added [Type] Code Quality Issues or PRs that relate to code quality [Block] Post Date Affects the Post Date Block [Feature] Block bindings labels Sep 15, 2025
@ockham
Copy link
Contributor Author

ockham commented Sep 15, 2025

Maybe we'll eventually need a block-agnostic version of that filter, i.e. block_bindings_supported_attributes 🤔

@github-actions
Copy link

github-actions bot commented Sep 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo
Copy link
Member

gziolo commented Sep 15, 2025

Maybe we'll eventually need a block-agnostic version of that filter, i.e. block_bindings_supported_attributes 🤔

Testing it with a real plugin is always helpful to validate the approach. I'm fine with both. No strong opinions on my end.

@ockham
Copy link
Contributor Author

ockham commented Sep 15, 2025

Maybe we'll eventually need a block-agnostic version of that filter, i.e. block_bindings_supported_attributes 🤔

#71663

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has some temporary issues, but the code changes make perfect sense to me 👍🏻

@ockham ockham changed the title Date block: Move block_bindings_supported_attributes filter to compat layer Date block: Move block_bindings_supported_attributes filter to compat layer Sep 15, 2025
@github-actions
Copy link

Flaky tests detected in c8d1b03.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17732654047
📝 Reported issues:

@ockham ockham merged commit 09c0868 into trunk Sep 15, 2025
104 of 106 checks passed
@ockham ockham deleted the move/block-bindings-supported-attributes-filter-out-of-date-block-code branch September 15, 2025 12:56
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Post Date Affects the Post Date Block [Feature] Block bindings [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants