-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Date block: Move block_bindings_supported_attributes filter to compat layer
#71662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date block: Move block_bindings_supported_attributes filter to compat layer
#71662
Conversation
|
Maybe we'll eventually need a block-agnostic version of that filter, i.e. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Testing it with a real plugin is always helpful to validate the approach. I'm fine with both. No strong opinions on my end. |
|
gziolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI has some temporary issues, but the code changes make perfect sense to me 👍🏻
block_bindings_supported_attributes filter to compat layer
|
Flaky tests detected in c8d1b03. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17732654047
|
What?
Move the
block_bindings_supported_attributes_core/post-datethat was added in #71389 to add Block Bindings support for the Date block'sdatetimeattribute out of the Date block code and into Gutenberg's WP 6.8 compatibility layer code.Why?
See related discussion here.
Testing Instructions
Refer to #70585.