GitHub Actions: Add path filtering to End-to-End Tests workflow#71602
GitHub Actions: Add path filtering to End-to-End Tests workflow#71602Adi-ty wants to merge 2 commits intoWordPress:trunkfrom
Conversation
- Add paths-ignore to skip E2E tests for non-functional changes Addresses issue WordPress#71526
t-hamano
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
left a comment
desrosj
left a comment
There was a problem hiding this comment.
Hi @Adi-ty,
Thank you for working on this! Instead of utilizing paths-ignore, can we instead use paths? There are two main reasons why this is preferred:
- This more closely matches how the WordPress/wordpress-develop workflows are already set up
- It's a bit more future proof in that new files/file types/directories will not cause the workflow to run.
It's not always obvious when and where this list will need updating. By using in include list, it will be clear because the workflow will not run when contributors are expecting it to. The list will likely also be much shorter.
3 participants
What?
Closes #71526
Adds comprehensive path filtering to the End-to-End Tests workflow to prevent unnecessary test runs when changes don't affect functionality.
Why?
The End-to-End Tests workflow currently runs on every PR regardless of the changes being proposed.
How?
Add
paths-ignorelist in.github/workflows/end2end-test.ymlto skip E2E tests.