Repository navigation
Time to Read: Stabilize block - #71588
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @peteringersoll, @jamiemarsland. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
There's a reason we didn't stabilize this block. See #53776 (comment). Additionally, if we release this PR, we will need to reopen the core backports PR and include the backports changelog in this PR. |
|
Flaky tests detected in 9cc22cb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18127377626
|
|
Thanks @t-hamano.
It looks like many of the reasons for not stabilising this block could be addressed with the ideas in #71583. Perhaps we could try some of those ideas and then reconsider stabilising the block. What do you think? |
I agree, it would be nice to try out some implementations of the ideas before moving forward with this PR. |
scruffian
left a comment
There was a problem hiding this comment.
Now this block has a range option and a word count, I think we can bring it in.
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Before merging, I'd appreciate it if you check the following points:
- Update the
wp_word_countfunction. The core backport PR has already been reviewed, and the internal logic has changed slightly. - If I remember correctly, this code is no longer needed.
- Add backport changelog. Core backport PR is WordPress/wordpress-develop#4430.
|
@mikachan Sorry for pushing some changes, but I think this PR is ready to be merged. @scruffian What do you think? |
t-hamano
left a comment
There was a problem hiding this comment.
In my testing, everything works fine. I'm happy that this block is finally stable 🎉
ntsekouras
left a comment
There was a problem hiding this comment.
Nice 💯 ! Let's get this in!
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Closes #53776
Why?
This stabilises the Time to Read block so we can include this block in WP 6.9. I think it's also important to address #71583 in time for WP 6.9, but as this is an enhancement rather than a breaking change, I don't think it matters if the block is stabilised first.
How?
Removes the
experimentalflag, and moves thel10n.phpfile inlib/compat/wordpress-6.9/l10n.php, ready for inclusion in 6.9.Testing Instructions