Skip to content

Time to Read: Stabilize block - #71588

Merged
ntsekouras merged 7 commits into
trunkfrom
update/stabilise-time-to-read
Oct 3, 2025
Merged

ntsekouras merged 7 commits into
trunkfrom
update/stabilise-time-to-read

Conversation

@mikachan

Copy link
Copy Markdown
Member

What?

Closes #53776

Why?

This stabilises the Time to Read block so we can include this block in WP 6.9. I think it's also important to address #71583 in time for WP 6.9, but as this is an enhancement rather than a breaking change, I don't think it matters if the block is stabilised first.

How?

Removes the experimental flag, and moves the l10n.php file in lib/compat/wordpress-6.9/l10n.php, ready for inclusion in 6.9.

Testing Instructions

  1. Disable experimental blocks in GB settings
  2. Ensure the Time to Read block can still be inserted

@mikachan mikachan added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Sep 10, 2025
@mikachan
mikachan requested a review from ndiego as a code owner September 10, 2025 15:57
@mikachan mikachan added the [Block] Time to Read Affects the Time to Read Block label Sep 10, 2025
@github-actions

github-actions Bot commented Sep 10, 2025 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @peteringersoll, @jamiemarsland.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: peteringersoll, jamiemarsland.

Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: torounit <toro_unit@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: masteradhoc <masteradhoc@git.wordpress.org>
Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
Co-authored-by: pbearne <pbearne@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano

t-hamano commented Sep 10, 2025 •

Copy link
Copy Markdown
Contributor

There's a reason we didn't stabilize this block. See #53776 (comment).

cc @joedolson @alexstine

Additionally, if we release this PR, we will need to reopen the core backports PR and include the backports changelog in this PR.

WordPress/wordpress-develop#4430

@github-actions

github-actions Bot commented Sep 10, 2025 •

Copy link
Copy Markdown

Flaky tests detected in 9cc22cb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18127377626
📝 Reported issues:

@mikachan

Copy link
Copy Markdown
Member Author

Thanks @t-hamano.

There's a reason we didn't stabilize this block. See #53776 (comment).

It looks like many of the reasons for not stabilising this block could be addressed with the ideas in #71583. Perhaps we could try some of those ideas and then reconsider stabilising the block. What do you think?

@t-hamano

Copy link
Copy Markdown
Contributor

Perhaps we could try some of those ideas and then reconsider stabilising the block. What do you think?

I agree, it would be nice to try out some implementations of the ideas before moving forward with this PR.

@scruffian scruffian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this block has a range option and a word count, I think we can bring it in.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Before merging, I'd appreciate it if you check the following points:

@t-hamano

t-hamano commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

@mikachan Sorry for pushing some changes, but I think this PR is ready to be merged.

@scruffian What do you think?

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing, everything works fine. I'm happy that this block is finally stable 🎉

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 ! Let's get this in!

@ntsekouras
ntsekouras merged commit 271de62 into trunk Oct 3, 2025
70 checks passed
@ntsekouras
ntsekouras deleted the update/stabilise-time-to-read branch October 3, 2025 09:37
@github-project-automation github-project-automation Bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Oct 3, 2025
@github-actions github-actions Bot added this to the Gutenberg 21.9 milestone Oct 3, 2025
@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin, New Block.
  • Labels found: [Type] Task, New Block, [Block] Time to Read.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Time to Read Affects the Time to Read Block New Block Suggestion for a new block [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

Development

Successfully merging this pull request may close these issues.

Stabilize Time to Read block

5 participants