Skip to content

Experiment: Add content only block controls to Inspector Panel #71577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Experiment: Add content only block controls to Inspector Panel #71577

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cb2b37c
Update derived block editing modes to support content only template l…
talldan Dec 4, 2024
e4b5aa9
Fix `getEnabledBlockParents` test
talldan Sep 8, 2025
fcb9d90
Make unsynced patterns contentOnly by default
talldan Sep 5, 2025
110543e
Consider blocks with `patternName` as sections
talldan Sep 5, 2025
8b2215a
Fix failing test by adding some back compat
talldan Sep 8, 2025
7ef7e40
Guard behind an experiment
andrewserong Sep 9, 2025
a418ac2
Insert parsed patterns via the slash inserter
talldan Sep 9, 2025
06b32fc
Fix test
talldan Sep 10, 2025
361f633
Hide variation selector for section blocks
talldan Sep 10, 2025
5641787
Show shuffle styles for any section in any mode
talldan Sep 10, 2025
f7ed41e
Use experiment flag for a couple of changes
talldan Sep 10, 2025
cbdced9
Combine select calls
talldan Sep 10, 2025
73b967f
Hide transforms for sections when experiment is active
talldan Sep 10, 2025
5947865
Boilerplate
talldan Sep 10, 2025
c7281c0
v1
talldan Sep 10, 2025
7dd9a1b
Fixes
talldan Sep 10, 2025
d86f9cf
Small improvements:
talldan Sep 10, 2025
04a67c2
Add block icon
talldan Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add block icon
  • Loading branch information
@talldan
talldan committed Sep 10, 2025
commit 04a67c27279ae7db96de367b28b3fce6055b1088
11 changes: 10 additions & 1 deletion packages/block-editor/src/components/content-only-controls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { store as blocksStore } from '@wordpress/blocks';
import {
__experimentalToolsPanel as ToolsPanel,
__experimentalToolsPanelItem as ToolsPanelItem,
__experimentalHStack as HStack,
TextControl,
} from '@wordpress/components';
import { useDispatch, useSelect } from '@wordpress/data';
Expand All @@ -14,7 +15,9 @@ import { __unstableStripHTML as stripHTML } from '@wordpress/dom';
* Internal dependencies
*/
import { store as blockEditorStore } from '../../store';
import BlockIcon from '../block-icon';
import useBlockDisplayTitle from '../block-title/use-block-display-title';
import useBlockDisplayInformation from '../use-block-display-information';

function RichTextControl( { label, value, setValue } ) {
return (
Expand Down Expand Up @@ -121,6 +124,7 @@ function BlockControls( { clientId } ) {
clientId,
context: 'list-view',
Copy link
Contributor

@jeryj jeryj Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels odd since we're not in the list view. Maybe we need to change the whatever the context is of this list-view name to something more generic?

Copy link
Contributor Author

@talldan talldan Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't thought too much about it, it's just code I lifted from the BlockQuickNavigation component.

} );
const blockInformation = useBlockDisplayInformation( clientId );

if ( ! contentAttributesWithControls?.length ) {
// TODO - we might still want to show a placeholder for blocks with no controls.
Expand All @@ -130,7 +134,12 @@ function BlockControls( { clientId } ) {

return (
<ToolsPanel
label={ blockTitle }
label={
<HStack spacing={ 1 }>
<BlockIcon icon={ blockInformation?.icon } />
<div>{ blockTitle }</div>
</HStack>
}
panelId={ clientId }
resetAll={ () => {
updateBlockAttributes(
Expand Down
Loading