-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Site Editor: make less prominent Addtional CSS UI #71550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: -19 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a18a176. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17762141572
|
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
tyxla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for being open to try out different things @t-hamano! 🚀
|
Thanks for the review! There were a lot of things to consider, but I think we finally settled on the ideal UI 😄 |
* Site Editor: make less prominent Addtional CSS UI * Add navigation button to blocks section * Update packages/edit-site/src/components/global-styles/screen-css.js Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/screen-css.js Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> * Move Additional CSS button into elipsis menu item --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>

Follow up #71537
See #71537 (comment), #71537 (comment)
What?
By making the additional CSS UI less prominent, try to implicitly encourage the use of a more ideal tool (the global styles UI).
How?
Remove the text above the button.Change the screen title from "CSS" to "Additional CSS" to emphasize that this section is optional.Change the screen description to a passive one.Update: The Add CSS button has been moved into the ellipsis menu in the header. See this discussion for more details: #71550 (comment)
Testing Instructions
There are no changes in terms of functionality.
Screenshots or screencast
ba1aaaaba0fdc45a78dc85a532572624.mp4