-
Notifications
You must be signed in to change notification settings - Fork 4.6k
i18n: remove unnecessary JS file #71549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.93 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍 Makes sense to me this should be resolving to the index.ts now.
Edit: I also did a check in case there's any leftover references to index.js with the specific extension and was unable to find any.
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org>
Follow up #70843
Originally reported on Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1757009849427419
What?
Although it is unstable, it has been reported that the
build-module/index.js.mapfile may have broken JSON data.My guess is that the problem was caused by forgetting to delete the
index.jsfile when the i18n package was migrated to TypeScript. I suspect that a conflict occurs because the two filesindex.jsandindex.tsare compiled with the same file as the output path.Testing Instructions
Nothing. If my prediction is correct, the same problem should not occur again.