Fix/in between inserter for gallery#71531
Open
levinbaria wants to merge 2 commits intoWordPress:trunkfrom
Open
Fix/in between inserter for gallery#71531levinbaria wants to merge 2 commits intoWordPress:trunkfrom
levinbaria wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @digitalex11. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shail-mehta
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #64222
Fixes missing block insertion points between items when an InnerBlocks area is laid out horizontally.
Why?
When InnerBlocks uses orientation="horizontal":
If children wrap onto a second row, the blue “insertion line with +” doesn’t appear between items on wrapped rows, so users can’t insert blocks where the cursor is.
In horizontally scrollable containers (e.g., sliders), insertion points don’t appear between items that are outside the initially visible area until scrolled into view.
How?
Testing Instructions
Buttons block (wrap case)
Create a page/post.
Insert Buttons. Add enough buttons so they wrap to a second line (reduce editor width if needed).
Hover between buttons on the second line.
✅ An insertion cue appears between the hovered items; clicking + inserts a new Button there.
Same for the Gallery Block as well.
Testing Instructions for Keyboard
Screenshots or screencast