Skip to content

Refactor Link UI controls with better props #71515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

Refactor Link UI controls with better props #71515

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78374ec
Refactor Link UI controls with better props
getdave Sep 5, 2025
5e2d857
Tweak LinkUiTools rendering condition
getdave Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Tweak LinkUiTools rendering condition
  • Loading branch information
@getdave
getdave committed Sep 5, 2025
commit 5e2d8570b58042d6662481895300307e285c9058
46 changes: 28 additions & 18 deletions packages/block-library/src/navigation-link/link-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,24 +142,34 @@ function UnforwardedLinkUI( props, ref ) {
onChange={ props.onChange }
onRemove={ props.onRemove }
onCancel={ props.onCancel }
renderControlBottom={ () => (
<LinkUITools
focusAddBlockButton={ focusAddBlockButton }
focusAddPageButton={ focusAddPageButton }
setAddingBlock={ () => {
setAddingBlock( true );
setFocusAddBlockButton( false );
} }
setAddingPage={ () => {
setAddingPage( true );
setFocusAddPageButton( false );
} }
canAddPage={
permissions?.canCreate && type === 'page'
}
canAddBlock={ blockEditingMode === 'default' }
/>
) }
renderControlBottom={ () => {
// Don't show the tools when there is submitted link (preview state).
if ( link?.url?.length ) {
return null;
}

return (
<LinkUITools
focusAddBlockButton={ focusAddBlockButton }
focusAddPageButton={ focusAddPageButton }
setAddingBlock={ () => {
setAddingBlock( true );
setFocusAddBlockButton( false );
} }
setAddingPage={ () => {
setAddingPage( true );
setFocusAddPageButton( false );
} }
canAddPage={
permissions?.canCreate &&
type === 'page'
}
canAddBlock={
blockEditingMode === 'default'
}
/>
);
} }
/>
</div>
) }
Expand Down
Loading