Skip to content

Experiment: Make unsynced patterns content only by default #71512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 11, 2025
Merged

Experiment: Make unsynced patterns content only by default #71512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cb2b37c
Update derived block editing modes to support content only template l…
talldan Dec 4, 2024
e4b5aa9
Fix `getEnabledBlockParents` test
talldan Sep 8, 2025
fcb9d90
Make unsynced patterns contentOnly by default
talldan Sep 5, 2025
110543e
Consider blocks with `patternName` as sections
talldan Sep 5, 2025
8b2215a
Fix failing test by adding some back compat
talldan Sep 8, 2025
7ef7e40
Guard behind an experiment
andrewserong Sep 9, 2025
a418ac2
Insert parsed patterns via the slash inserter
talldan Sep 9, 2025
06b32fc
Fix test
talldan Sep 10, 2025
361f633
Hide variation selector for section blocks
talldan Sep 10, 2025
5641787
Show shuffle styles for any section in any mode
talldan Sep 10, 2025
f7ed41e
Use experiment flag for a couple of changes
talldan Sep 10, 2025
cbdced9
Combine select calls
talldan Sep 10, 2025
73b967f
Hide transforms for sections when experiment is active
talldan Sep 10, 2025
53b33c1
Optional chain pattern properties
talldan Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use experiment flag for a couple of changes
  • Loading branch information
@talldan
talldan committed Sep 10, 2025
commit f7ed41e3575c2cc4c65f19073594cb55446e5268
13 changes: 11 additions & 2 deletions packages/block-editor/src/components/block-toolbar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@ export function PrivateBlockToolbar( {

const _isZoomOut = isZoomOut();

// The switch style button appears more prominently with the
// content only pattern experiment.
const _showSwitchSectionStyleButton =
window?.__experimentalContentOnlyPatternInsertion
? _isZoomOut || isSectionBlock( selectedBlockClientId )
: _isZoomOut ||
( isNavigationModeEnabled &&
editingMode === 'contentOnly' &&
isSectionBlock( selectedBlockClientId ) );

return {
blockClientId: selectedBlockClientId,
blockClientIds: selectedBlockClientIds,
Expand All @@ -153,8 +163,7 @@ export function PrivateBlockToolbar( {
showSlots: ! _isZoomOut,
showGroupButtons: ! _isZoomOut,
showLockButtons: ! _isZoomOut,
showSwitchSectionStyleButton:
_isZoomOut || isSectionBlock( selectedBlockClientId ),
showSwitchSectionStyleButton: _showSwitchSectionStyleButton,
hasFixedToolbar: getSettings().hasFixedToolbar,
isNavigationMode: isNavigationModeEnabled,
};
Expand Down
5 changes: 4 additions & 1 deletion packages/block-editor/src/components/block-variation-transforms/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ function __experimentalBlockVariationTransforms( { blockClientId } ) {
} );
};

if ( ! variations?.length || isContentOnly || isSection ) {
const hideVariationsForSections =
Copy link
Contributor

@tellthemachines tellthemachines Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to hide the transforms menu? It's still there and usable:

Screenshot 2025-09-10 at 3 43 51 pm

Copy link
Contributor Author

@talldan talldan Sep 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hides the variations on the block card for groups. Only remembered this one is still there after doing it 😄 .

Copy link
Contributor Author

@talldan talldan Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit that should address this.

window?.__experimentalContentOnlyPatternInsertion && isSection;

if ( ! variations?.length || isContentOnly || hideVariationsForSections ) {
return null;
}

Expand Down