Skip to content

Dataform: Add new telephone field type and field control #71498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 4, 2025
Merged

Dataform: Add new telephone field type and field control #71498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
427b9ac
Dataform: Add new `telephone` field type and field control
ntsekouras Sep 4, 2025
90d250e
add changelog
ntsekouras Sep 4, 2025
c75cb4b
add input wrapper
ntsekouras Sep 4, 2025
c42e972
move type definition
ntsekouras Sep 4, 2025
e095dea
move in utils
ntsekouras Sep 4, 2025
d191987
remove tel regex validation
ntsekouras Sep 4, 2025
9092973
update validation story
ntsekouras Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move type definition
  • Loading branch information
@ntsekouras
ntsekouras committed Sep 4, 2025
commit c42e9725aaf1bd4f4836e4dc3b2a2cf8717b287d
9 changes: 8 additions & 1 deletion packages/dataviews/src/dataform-controls/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@ import { useCallback, useState } from '@wordpress/element';
/**
* Internal dependencies
*/
import type { DataFormInputControlProps } from '../types';
import type { DataFormControlProps } from '../types';
import { unlock } from '../lock-unlock';

const { ValidatedTextControl } = unlock( privateApis );

export type DataFormInputControlProps< Item > = DataFormControlProps< Item > & {
/**
* The input type of the control.
*/
type?: 'text' | 'email' | 'tel';
};

export default function Input< Item >( {
data,
field,
Expand Down
7 changes: 0 additions & 7 deletions packages/dataviews/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,13 +284,6 @@ export type DataFormControlProps< Item > = {
operator?: Operator;
};

export type DataFormInputControlProps< Item > = DataFormControlProps< Item > & {
/**
* The input type of the control.
*/
type?: 'text' | 'email' | 'tel';
};

export type DataViewRenderFieldProps< Item > = {
item: Item;
field: NormalizedField< Item >;
Expand Down
Loading