Skip to content

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Sep 4, 2025

What?

This PR add a new telephone field type and field control (input with tel type) to provide more controls for consumers to be used out of the box.

Since email and tel are using the text control already and are pretty identical in props and functionality, I reused the Text control by just passing the type prop.

Testing Instructions

  1. Everything should work as before
  2. In storybook npm run storybook:dev
  3. You should also test the email type/field.

Screenshots or screencast

Before After

@ntsekouras ntsekouras self-assigned this Sep 4, 2025
@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Sep 4, 2025
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Flaky tests detected in 9092973.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17461444603
📝 Reported issues:

@oandregal
Copy link
Member

@ntsekouras could you also update the DataForm:Validation story to include the new component?

@ntsekouras
Copy link
Contributor Author

@ntsekouras could you also update the DataForm:Validation story to include the new component?

done

@oandregal oandregal merged commit aad5ae1 into trunk Sep 4, 2025
68 checks passed
@oandregal oandregal deleted the add/telephone-field-type-and-control branch September 4, 2025 13:55
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants