Navigation Link: Show 'Create page' button in Write Mode while hiding 'Add block' #71489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass blockEditingMode prop to LinkUITools component - Conditionally render 'Add block' button only in default mode - 'Create page' button remains visible in all modes when permissions allow - Improves Write Mode UX by hiding non-content UI elements
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 4, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Oh, good idea! Just double-checking, but I needed to add the "role": "content" values in my local env to test this (as in #71213), that's expected, right?
Looking good:
Within design mode
Write mode (add block is hidden, but add page is visible)
LGTM!
Contributor
Author
|
Yeh sorry I should have added those instructions. My bad! Thanks for working around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows "Add page" tool to show in Write Mode (when block is in
contentOnly).Why
PR #71213 previously hid the entire LinkUITools component in contentOnly mode, but this was too restrictive. Users should still be able to create new pages in Write Mode, as this is a content-related action. Only non-content UI elements like 'Add block' should be hidden.
How
blockEditingModeprop to LinkUITools componentblockEditingMode === 'default'Testing
Screenshots
[Screenshots to be added]
Breaking Changes
None - this is a UX improvement that maintains existing functionality.
Related