-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Navigation Link: Change 'Add page' to 'Create page' button text #71487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follow-up to #71188 addressing review feedback from @scruffian. The button text is changed from 'Add page' to 'Create page' to better reflect the action being performed - creating a new page entity rather than just adding an existing page to the navigation.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee2c17f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17434836344
|
What
Follow-up to #71188 addressing review feedback from @scruffian.
Changes the button text from 'Add page' to 'Create page' in the Navigation Link UI.
Why
As noted in the review comment, 'Create' makes more sense here than 'Add' - 'Adding' is the process of putting the link into the navigation, while 'Creating' is the process of actually making the entity.
How
Simple text change in the button label from
__( 'Add page' )to__( 'Create page' )in the LinkUI component.Testing
Screenshots