Skip to content

Image block: Save <figcaption> if caption attr is bound #71483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 17, 2025
Merged

Image block: Save <figcaption> if caption attr is bound #71483

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
487741e
Image block: Save `<figcaption>` if `caption` attr is bound
ockham Sep 3, 2025
8bd45b8
Block Bindings: Support Image block's caption attr
ockham Sep 3, 2025
87afa9c
Image Block: Save figcaption if block has pattern overrides
ockham Sep 3, 2025
b21bbc7
Image block: Enable caption control if attribute is bound
ockham Sep 3, 2025
f9103e5
Block Bindings: Support Image block caption attribute
ockham Sep 15, 2025
bfd6b8d
Add backport changelog
ockham Sep 15, 2025
91ca74b
Add test fixture
ockham Sep 16, 2025
3b103b2
Use new block-agnostic filter
ockham Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test fixture
  • Loading branch information
@ockham
ockham committed Sep 16, 2025
commit 91ca74b4c28622875c6eac43f43ee2dc257272ea
3 changes: 3 additions & 0 deletions test/integration/fixtures/blocks/core__image__caption-block-bindings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<!-- wp:image {"metadata":{"bindings":{"caption":{"source":"core/post-data","args":{"key":"date"}}}}} -->
<figure class="wp-block-image"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==" alt="" /><figcaption class="wp-element-caption"></figcaption></figure>
<!-- /wp:image -->
22 changes: 22 additions & 0 deletions test/integration/fixtures/blocks/core__image__caption-block-bindings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[
{
"name": "core/image",
"isValid": true,
"attributes": {
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
"metadata": {
"bindings": {
"caption": {
"source": "core/post-data",
"args": {
"key": "date"
}
}
}
}
},
"innerBlocks": []
}
]
22 changes: 22 additions & 0 deletions test/integration/fixtures/blocks/core__image__caption-block-bindings.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[
{
"blockName": "core/image",
"attrs": {
"metadata": {
"bindings": {
"caption": {
"source": "core/post-data",
"args": {
"key": "date"
}
}
}
}
},
"innerBlocks": [],
"innerHTML": "\n<figure class=\"wp-block-image\"><img src=\"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==\" alt=\"\" /><figcaption class=\"wp-element-caption\"></figcaption></figure>\n",
"innerContent": [
"\n<figure class=\"wp-block-image\"><img src=\"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==\" alt=\"\" /><figcaption class=\"wp-element-caption\"></figcaption></figure>\n"
]
}
]
3 changes: 3 additions & 0 deletions test/integration/fixtures/blocks/core__image__caption-block-bindings.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<!-- wp:image {"metadata":{"bindings":{"caption":{"source":"core/post-data","args":{"key":"date"}}}}} -->
<figure class="wp-block-image"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==" alt=""/><figcaption class="wp-element-caption"></figcaption></figure>
<!-- /wp:image -->