Skip to content

Search: Border radius presets work correctly #71481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2025
Merged

Search: Border radius presets work correctly #71481

merged 4 commits into from
Sep 4, 2025

Conversation

@shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Sep 3, 2025

What?

The border radius presets introduced in #67544 are now supported.
The border radius of the Search block is a dynamic block and must be handled individually.

border

edit.js also now supports borderProps.

How?

Testing Instructions

  1. Add the border radius property to the settings in theme.json.
  2. Place the Search block and verify that the border presets work correctly.

Testing Instructions for Keyboard

Screenshots or screencast

before

before-border.1.mp4

after

after-border.1.mp4

@github-actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Search Affects the Search Block - used to display a search field Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 3, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Sep 3, 2025

Thanks for the PR! The border radius preset support is a new feature in the WP 6.9 release, so let's fix this issue in the release.

cc @aaronrobertshaw @andrewserong

@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Sep 3, 2025
@t-hamano t-hamano moved this from 🔎 Needs Review to 📥 Todo in WordPress 6.9 Editor Tasks Sep 3, 2025
@t-hamano t-hamano moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.9 Editor Tasks Sep 3, 2025
andrewserong
andrewserong approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @t-hamano, and terrific work @shimotmk! This is testing great for me in the editor and site frontend:

image

Note that the Search block's support for border in global styles applies to the outer-most area of the Search block, so there didn't need to be any changes made to how global styles works in this PR 👍

Just left a couple of tiny nit comments that look to be a copy/paste typo, but otherwise, LGTM!

shimotmk and others added 2 commits September 4, 2025 10:36
@shimotmk @andrewserong
Update packages/block-library/src/search/index.php
4ee5c69 
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
@shimotmk @andrewserong
Update packages/block-library/src/search/index.php
4917de6 
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
@andrewserong
Copy link
Contributor

andrewserong commented Sep 4, 2025

Thanks for the updates! I'll merge this in, now.

@andrewserong andrewserong merged commit c06bd37 into WordPress:trunk Sep 4, 2025
76 of 77 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Sep 4, 2025
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 4, 2025
@shimotmk
Copy link
Contributor Author

shimotmk commented Sep 4, 2025

@andrewserong
Thanks for the review!

@shimotmk shimotmk deleted the fix/search/border-radius branch September 4, 2025 04:26
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewserong andrewserong andrewserong approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Search Affects the Search Block - used to display a search field Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

WordPress 6.9 Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 21.7

Development

Successfully merging this pull request may close these issues.

3 participants

@shimotmk @t-hamano @andrewserong