Skip to content

DataViews: Fix grid padding values on mobile viewports #71455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

DataViews: Fix grid padding values on mobile viewports #71455

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e459bc
Match grid responsive container query to dataviews container query
talldan Sep 2, 2025
d66e357
Ensure group header padding matches rest of dataviews on mobile viewp…
talldan Sep 2, 2025
64ecb40
Add changelog entry
talldan Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Match grid responsive container query to dataviews container query
  • Loading branch information
@talldan
talldan committed Sep 2, 2025
commit 1e459bc47f32d6c6fcf14c34d542c9ad24fafb92
6 changes: 3 additions & 3 deletions packages/dataviews/src/dataviews-layouts/grid/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
padding: 0 $grid-unit-60 $grid-unit-30;
container-type: inline-size;
/**
* Breakpoints were adjusted from media queries breakpoints to account for
* the sidebar width. This was done to match the existing styles we had.
* Match the padding applied to other DataViews components at the same
* max-width.
*/
@container (max-width: 480px) {
@container (max-width: 430px) {
Copy link
Contributor

@tellthemachines tellthemachines Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, I wonder why the discrepancy was introduced? I believe the 480px value was reached from some calculation based on the gutenberg media queries with the site editor sidebar width. I can't find any explanation for where the 430 value comes from but I see it's also used in edit-site.

Copy link
Contributor Author

@talldan talldan Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a reason. The container query originally had some grid related css in it, so maybe the styles were more focused on the gird.

padding-left: $grid-unit-30;
padding-right: $grid-unit-30;
}
Expand Down