Buttons: Add support for text color at the Buttons block level#71411
Open
im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Open
Buttons: Add support for text color at the Buttons block level#71411im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Buttons block level#71411im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Conversation
im3dabasia
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shail-mehta
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for text color at the Buttons block level, similar to what is already available on individual Button block
Closes #57606
Why?
There is a need to provide a text color option at the Buttons block level so that all inner Button blocks can consistently inherit the same color from the parent, instead of setting the color on each Button individually.
Additionally, when Buttons are placed inside a Group and the Group has a text color applied, the Buttons block currently does not inherit this color. This PR fixes that inheritance issue as well.
How?
packages/block-library/src/buttons/block.json.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
The button block is not inheritting colors given from group block. Intuitively one would want everything inside the group block to have the color chosen by the Group block
After
Now, the Button correctly inherits the color from the Group block. If a color is set at the Buttons block level, that color is used instead. Lastly, if a color is applied directly to the Button block, that color is applied.
Screen.Recording.2025-08-29.at.3.18.23.PM.mov
this would have the highest priority