Skip to content

Fix: Hide resolved comments in unpinned mode #71409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

Fix: Hide resolved comments in unpinned mode #71409

merged 2 commits into from
Sep 12, 2025

Conversation

@R1shabh-Gupta
Copy link
Contributor

@R1shabh-Gupta R1shabh-Gupta commented Aug 29, 2025 •
edited
Loading

What?

Closes #71394

This PR filters out resolved comments from the unpinned collaboration sidebar to declutter the editor display while keeping them visible in the pinned sidebar for complete comment history.

Why?

When comments are resolved, they should disappear from the default unpinned view to reduce visual clutter and help editors focus on active, unresolved comments that need attention. Previously, both resolved and unresolved comments were shown in all sidebar modes.

How?

  • Added filtering logic to exclude comments with status === 'approved' from the unpinned sidebar
  • Preserved all comments (resolved + unresolved) in the pinned sidebar for full history access
  • Refactored variable names for clarity (sortedThreads → unresolvedSortedThreads)

Testing Instructions

  1. Open the Gutenberg editor with a post or page
  2. Add some blocks and create comments on them
  3. Resolve one or more comments by clicking the "Resolve" button (checkmark icon)
  4. Open the unpinned collaboration sidebar
  5. Verify that resolved comments do not appear in the unpinned sidebar
  6. Open the pinned collaboration sidebar
  7. Verify that all comments (resolved + unresolved) appear in the sidebar

Screenshots or screencast

Before

Before.mov

After

After.mov

@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review August 29, 2025 09:29
@github-actions
Copy link

github-actions bot commented Aug 29, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added [Type] Bug An existing feature does not function as intended Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Aug 29, 2025
@adamsilverstein adamsilverstein self-requested a review September 7, 2025 05:09
adamsilverstein
adamsilverstein reviewed Sep 7, 2025
View reviewed changes
@adamsilverstein
Copy link
Member

adamsilverstein commented Sep 7, 2025

@R1shabh-Gupta - this worked well in my testing, thanks for the PR!

I left some small feedback on the filter approach.

@R1shabh-Gupta
Copy link
Contributor Author

R1shabh-Gupta commented Sep 7, 2025

Hey @adamsilverstein,
Thank you for the feedback! I’ve updated the code to address the issue.

@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Sep 10, 2025
adamsilverstein
adamsilverstein approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@adamsilverstein
Copy link
Member

adamsilverstein commented Sep 11, 2025

@t-hamano does this one look ok to you?

Mamaduka
Mamaduka approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try.

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 12, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 12, 2025
@Mamaduka Mamaduka merged commit b7cb98b into WordPress:trunk Sep 12, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Sep 12, 2025
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 12, 2025
@t-hamano t-hamano added [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting and removed Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 4, 2025
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@t-hamano t-hamano Awaiting requested review from t-hamano

Assignees

@R1shabh-Gupta R1shabh-Gupta

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended

Projects

WordPress 6.9 Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 21.7

Development

Successfully merging this pull request may close these issues.

Only unresolved comments should be shown in unpinned mode

5 participants

@R1shabh-Gupta @adamsilverstein @Mamaduka @shail-mehta @t-hamano