-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Validated form controls: Fix Sass var handling for red color #71391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: -13 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 9a81db0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17427564512
|
tyxla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well 👍 ![]()
|
Is there a lint rule that could help prevent these kinds of issues? I wonder if dollar-variable-no-missing-interpolation would do it? (if it's not already enabled) |
Hmm, I didn't think of that! Would be nice if there was a quick automated check. But that
|
What?
Fixes Sass variable handling for the red color in validated form controls.
Why?
They were not properly referencing the Sass color variable for red, rendering the
$alert-redstring itself in the resulting stylesheet.How?
Updates the Sass import/usage to properly reference the
$alert-redvariable.Testing Instructions
npm run storybook:devand go to the story forValidatedInputControl.Screenshots or screencast