Accordion: Add an "Add" button #71388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +48 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 29, 2025
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Nice, I think we should try this, feel it out.
Contributor
|
It could use a code check. |
MaggieCabrera
approved these changes
Aug 29, 2025
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
The code is looking good to me
mikachan
force-pushed
the
add/accordion-add-button
branch
from
947eef4 to
5a8cf6c
Compare
|
Flaky tests detected in 5a8cf6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17321483217
|
Mamaduka
reviewed
Sep 19, 2025
Comment on lines
+58
to
+61
| label={ __( 'Add accordion content block' ) } | ||
| onClick={ addAccordionContentBlock } | ||
| > | ||
| { __( 'Add' ) } |
Member
There was a problem hiding this comment.
I might be mistaken, but I thought we shouldn't use different labels when a button has an actual text label, from an a11y perspective.
cc @joedolson, @t-hamano
Contributor
There was a problem hiding this comment.
we shouldn't use different labels when a button has an actual text label, from an a11y perspective.
This is how I understand it too. I think we should remove the label prop (aria-label),
Member
Author
There was a problem hiding this comment.
Ah, I agree, I don't think we should have the label here at all. I thought I used a pattern I found in another block, but the only other example I can see is the Gallery block, which just uses "Add" as the button text with no label. Will spin up a PR with a fix!
Member
Author
There was a problem hiding this comment.
I see, we'll address it in #71750
Ah sorry, didn't see these comments until after creating the PR 😅
Member
There was a problem hiding this comment.
We can do separate PRs. No problem.
Contributor
There was a problem hiding this comment.
Yes. If the context of the button is clear and it has visible text, it shouldn't also have a label prop. Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses these comments: #64119 (comment) & #64119 (comment)
Adds an "Add" button to the Accordion block.
Why?
This makes it easier to add more Accordion Content blocks to the Accordion block.
How?
Adds an "Add" button to the Accordion block toolbar:
This implementation is based on the "Add" button in the Gallery block:
Testing Instructions
Screenshots or screencast