Skip to content

Fix: Hide "View Post" link for non-viewable post types #71356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2025
Merged

Fix: Hide "View Post" link for non-viewable post types #71356

merged 3 commits into from
Sep 5, 2025

Conversation

@R1shabh-Gupta
Copy link
Contributor

@R1shabh-Gupta R1shabh-Gupta commented Aug 26, 2025

What?

Closes #71343

Hides the "View Post" link in the admin bar when editing synced patterns to prevent 404 errors.

Why?

When editing a synced pattern via "Edit original", the "View Post" link in the admin bar still appears and leads to a 404 error because patterns don't have public URLs. This creates a confusing user experience.

How?

Updated the useUpdatePostLinkListener hook to check if the current post type is viewable using postType?.viewable. For non-viewable post types, the "View Post" link is hidden using display: none.

Testing Instructions

  1. Open a new playground
  2. Open "Hello World" post in block editor from admin bar or post list in WP-Admin
  3. Disable "full screen mode"
  4. Insert some block(s) and convert them to a synced pattern
  5. Save the post
  6. Enter edit mode for that synced pattern via "Edit original" in tools bar
  7. Verify that the "View Post" button in the admin bar is now hidden
  8. Go back to editing the original post and confirm the "View Post" link is visible again

Screenshots or screencast

Before

Screen.Recording.2025-08-26.at.8.12.45.PM.mov

After

Screen.Recording.2025-08-26.at.8.11.00.PM.mov

@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review August 28, 2025 14:08
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia im3dabasia added [Type] Bug An existing feature does not function as intended [Package] Edit Post /packages/edit-post labels Aug 28, 2025
@R1shabh-Gupta
Copy link
Contributor Author

R1shabh-Gupta commented Sep 2, 2025

Hey @t-hamano,
Could you take a look at the PR when you get a chance? The "View Post" option is now hidden for all post types that are not viewable, using the approach you described in the issue comment.

I’d appreciate any feedback or suggestions you might have.

t-hamano
t-hamano reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think we need to restore the link again when we "back" from the synced pattern editing screen.

t-hamano
t-hamano approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 8f9c570 into WordPress:trunk Sep 5, 2025
78 of 79 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 5, 2025
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

Assignees

No one assigned

Labels

[Package] Edit Post /packages/edit-post [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 21.7

Development

Successfully merging this pull request may close these issues.

"View Post" link while editing synced pattern leads to 404

3 participants

@R1shabh-Gupta @t-hamano @im3dabasia