Update types of getCurrentPostId #71347
Conversation
kmanijak
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
im3dabasia
added
[Type] Code Quality
im3dabasia
left a comment
im3dabasia
left a comment
There was a problem hiding this comment.
Thanks for working on this PR. The change looks good 🚀
| * @param {Object} state Global application state. | ||
| * | ||
| * @return {?number} ID of current post. | ||
| * @return {?(string|number)} Template slug or current post ID. |
There was a problem hiding this comment.
| * @return {?(string|number)} Template slug or current post ID. | |
| * @return {?(string|number)} The current post ID or template slug. |
Let's emphasize the post ID.
There was a problem hiding this comment.
Good point. Updated in 7d658bb. I swapped types as well so there's more logical order.
3 participants
What?
Closes
Updating
select( 'core/editor' ).getCurrentPostId()return types.Why?
Type of
select( 'core/editor' ).getCurrentPostId()is incorrect as it may return string or number not only number.How?
Testing Instructions
select( 'core/editor' ).getCurrentPostId()-> numberselect( 'core/editor' ).getCurrentPostId()-> stringTesting Instructions for Keyboard
Screenshots or screencast