-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Command Palette: Make navigation commands available on all screens #71335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 18 commits into
WordPress:trunk
from
yashjawale:fix/command-palette-navigation-commands-availability
Sep 9, 2025
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
19f65b1
initial draft: move navigation commands to core commands
yashjawale b4c4600
Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…
yashjawale 44debcf
Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…
yashjawale c6bf218
Editor: Update command palette test for custom CSS navigation
yashjawale a8da2d5
Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…
yashjawale a61d7dd
fix: move custom css commands back to edit-site
yashjawale dc564bd
fix: update custom CSS command label
yashjawale 08d18c6
fix: update go to styles command label
yashjawale a12b460
fix: update navigation command labels with colon
yashjawale 1b85abf
fix: move commands from separate file to existing ones
yashjawale 652a29f
Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…
yashjawale 8fcbf58
fix: re-add global styles navigation commands to site editor
yashjawale 24ad592
fix: remove redundant global styles navigation command from site editor
yashjawale 44f7f04
fix: implement pages override command in site editor to resolve Menu …
yashjawale 324876f
Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…
yashjawale 4612e34
fix: filter Pages command in site editor navigation
yashjawale ba25952
Revert "fix: filter Pages command in site editor navigation"
yashjawale 8b561d7
revert: remove pages command override
yashjawale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it appears that the label overlaps with a command registered via the Menu API. Ideally, it should be moved to
site-editor.php?p=%2Fpagein the site editor, but we may have no choice but to delete this command and move it toedit.php?post_type=page.cc @youknowriad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to remove the command for now.
The alternative is to override the other command (unregister it and register this one instead when we're in the site editor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashjawale Would you like to try this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'll give that a try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me unregistering didn't seem to work, it was getting registered again...
Instead I've tried to filter commands in
admin-navigation-commands.jsitself which workedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I realized that we need a lot of code to override. In this PR, how about removing the "Go to: Pages" command from the
edit-siteand respecting the menu command? Perhaps we can try a better approach in a follow-up PR.