Command Palette: Make navigation commands available on all screens #71335

yashjawale · 2025-08-25T09:07:27Z

What?

This PR moves navigation commands out of @wordpress/edit-site to the @wordpress/core-commands package.

The move makes the command available outside of site editor

Why?

There are some specific commands for the site editor. Some commands should be available outside the editor as well, since they are essentially navigations that involve changing the URL.
Part of efforts to make command palette available across the dashboard

How?

The relevant code related to navigation commands are moved to @wordpress/core-commands package

Also the labels of commands are updated with Go to _ prefix, except for Style revisions, View site

Testing Instructions

Open a page where command palette is available except site editor
Invoke command palette with Cmd/Ctrl + K & search for the above commands

Screenshots or screencast

…ilability

github-actions · 2025-08-29T09:38:50Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yashjawale <yashjawale@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

yashjawale · 2025-08-29T09:40:11Z

I've moved the command functions to core commands package but View custom CSS command doesn't appear to work, even if its navigating to proper URL
The custom CSS panel doesn't appear to open for me even if the URL param is present

t-hamano · 2025-09-02T10:05:23Z

Thanks for working on this PR!

I've moved the command functions to core commands package but View custom CSS command doesn't appear to work, even if its navigating to proper URL
The custom CSS panel doesn't appear to open for me even if the URL param is present

Sorry, I misunderstood.

In fact, the Additional screen doesn't exist if no custom styles are defined:

This is why the panel won't open even when you run the correct URL from outside the site editor.

I remember there is an open PR that always enables the Additional CSS screen and a button to access it somewhere.

In this PR, I think it's okay to move the custom CSS commands back to the edit site. We can deal with it later.

yashjawale · 2025-09-02T14:03:59Z

Thanks!
I'll make the necessary changes

…ilability

yashjawale · 2025-09-03T11:15:32Z

Updated ✅

t-hamano · 2025-09-03T11:22:03Z

@yashjawale Thanks for the update!

The changes look good, but this PR is slightly related to #71476 and will likely cause conflicts. Let's move forward with this PR while taking into account the situation in 71476.

packages/edit-site/src/hooks/commands/use-common-commands.js

packages/core-commands/src/site-editor-global-styles-commands.js

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

…ilability

t-hamano · 2025-09-06T03:34:30Z

packages/core-commands/src/site-editor-navigation-commands.js

-					label: __( 'Pages' ),
+					label: __( 'Go to: Pages' ),


Unfortunately, it appears that the label overlaps with a command registered via the Menu API. Ideally, it should be moved to site-editor.php?p=%2Fpage in the site editor, but we may have no choice but to delete this command and move it to edit.php?post_type=page.

cc @youknowriad

I think it's ok to remove the command for now.

The alternative is to override the other command (unregister it and register this one instead when we're in the site editor)

The alternative is to override the other command (unregister it and register this one instead when we're in the site editor)

@yashjawale Would you like to try this approach?

Yes I'll give that a try

For me unregistering didn't seem to work, it was getting registered again...
Instead I've tried to filter commands in admin-navigation-commands.js itself which worked

Wow, I realized that we need a lot of code to override. In this PR, how about removing the "Go to: Pages" command from the edit-site and respecting the menu command? Perhaps we can try a better approach in a follow-up PR.

t-hamano · 2025-09-08T03:02:22Z

I've moved the command functions to core commands package but View custom CSS command doesn't appear to work, even if its navigating to proper URL
The custom CSS panel doesn't appear to open for me even if the URL param is present

Update: We should be able to address the problem above if #71537 is merged.

…API conflict

…ilability

yashjawale · 2025-09-08T12:10:33Z

Since #71537 is merged should I move custom CSS command back to core commands?

t-hamano · 2025-09-09T07:26:21Z

Since #71537 is merged should I move custom CSS command back to core commands?

I think this task can be addressed separately in a follow-up.

This reverts commit 4612e34.

t-hamano · 2025-09-09T08:00:51Z

@yashjawale Can you delete this and this too?

After that, we should be able to ship this PR.

yashjawale · 2025-09-09T08:07:31Z

Removed the override logic

t-hamano

LGTM! Thank you for your work on this PR until the end.

…71335) * initial draft: move navigation commands to core commands * Editor: Update command palette test for custom CSS navigation * fix: move custom css commands back to edit-site * fix: update custom CSS command label Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * fix: update go to styles command label Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * fix: update navigation command labels with colon * fix: move commands from separate file to existing ones * fix: re-add global styles navigation commands to site editor * fix: remove redundant global styles navigation command from site editor * fix: implement pages override command in site editor to resolve Menu API conflict * fix: filter Pages command in site editor navigation * Revert "fix: filter Pages command in site editor navigation" This reverts commit 4612e34. * revert: remove pages command override --------- Co-authored-by: yashjawale <yashjawale@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

…ordPress#71335) * initial draft: move navigation commands to core commands * Editor: Update command palette test for custom CSS navigation * fix: move custom css commands back to edit-site * fix: update custom CSS command label Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * fix: update go to styles command label Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * fix: update navigation command labels with colon * fix: move commands from separate file to existing ones * fix: re-add global styles navigation commands to site editor * fix: remove redundant global styles navigation command from site editor * fix: implement pages override command in site editor to resolve Menu API conflict * fix: filter Pages command in site editor navigation * Revert "fix: filter Pages command in site editor navigation" This reverts commit 4612e34. * revert: remove pages command override --------- Co-authored-by: yashjawale <yashjawale@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

yashjawale added 4 commits August 25, 2025 14:35

initial draft: move navigation commands to core commands

19f65b1

Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…

b4c4600

…ilability

Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…

44debcf

…ilability

Editor: Update command palette test for custom CSS navigation

c6bf218

yashjawale marked this pull request as ready for review August 29, 2025 09:38

yashjawale changed the title ~~[WIP] Command Palette: Make navigation commands available on all screens~~ Command Palette: Make navigation commands available on all screens Aug 29, 2025

t-hamano mentioned this pull request Sep 2, 2025

Command Palette: Make navigation commands available on all screens #71318

Closed

4 tasks

yashjawale added 2 commits September 3, 2025 15:40

Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…

a8da2d5

…ilability

fix: move custom css commands back to edit-site

a61d7dd

t-hamano reviewed Sep 5, 2025

View reviewed changes

yashjawale and others added 7 commits September 5, 2025 16:19

fix: update custom CSS command label

dc564bd

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

fix: update go to styles command label

08d18c6

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

fix: update navigation command labels with colon

a12b460

fix: move commands from separate file to existing ones

1b85abf

Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…

652a29f

…ilability

fix: re-add global styles navigation commands to site editor

8fcbf58

fix: remove redundant global styles navigation command from site editor

24ad592

t-hamano reviewed Sep 6, 2025

View reviewed changes

t-hamano added [Package] Core commands [Feature] Command Palette [Type] Enhancement A suggestion for improvement. labels Sep 6, 2025

t-hamano mentioned this pull request Sep 8, 2025

Site Editor: Always show Additional CSS button #71537

Merged

fix: implement pages override command in site editor to resolve Menu …

44f7f04

…API conflict

yashjawale added 2 commits September 8, 2025 16:51

Merge branch 'trunk' into fix/command-palette-navigation-commands-ava…

324876f

…ilability

fix: filter Pages command in site editor navigation

4612e34

Revert "fix: filter Pages command in site editor navigation"

ba25952

This reverts commit 4612e34.

revert: remove pages command override

8b561d7

t-hamano approved these changes Sep 9, 2025

View reviewed changes

t-hamano merged commit 0d75f88 into WordPress:trunk Sep 9, 2025
77 of 78 checks passed

github-actions bot added this to the Gutenberg 21.7 milestone Sep 9, 2025

yashjawale mentioned this pull request Sep 10, 2025

Command Palette: Move custom CSS command to core-commands from edit-site package #71565

Merged

maxschmeling mentioned this pull request Oct 7, 2025

Add BlockCanvasCover SlotFill #72119

Closed

Command Palette: Make navigation commands available on all screens #71335

Command Palette: Make navigation commands available on all screens #71335

Uh oh!

Conversation

yashjawale commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

How?

Testing Instructions

Screenshots or screencast

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashjawale commented Aug 29, 2025

Uh oh!

t-hamano commented Sep 2, 2025

Uh oh!

yashjawale commented Sep 2, 2025

Uh oh!

yashjawale commented Sep 3, 2025

Uh oh!

t-hamano commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t-hamano Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

youknowriad Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

t-hamano Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

yashjawale Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

yashjawale Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

t-hamano Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

t-hamano commented Sep 8, 2025

Uh oh!

yashjawale commented Sep 8, 2025

Uh oh!

t-hamano commented Sep 9, 2025

Uh oh!

t-hamano commented Sep 9, 2025

Uh oh!

yashjawale commented Sep 9, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yashjawale commented Aug 25, 2025 •

edited

Loading

github-actions bot commented Aug 29, 2025 •

edited

Loading