Skip to content

Modal headings and labels missing editor text color #71311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 4, 2025
Merged

Modal headings and labels missing editor text color #71311

merged 14 commits into from
Sep 4, 2025

Conversation

@kushagra-goyal-14
Copy link
Contributor

@kushagra-goyal-14 kushagra-goyal-14 commented Aug 22, 2025

What?

Closes #50448
This PR updates the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css.

Why?

How?

This PR is refreshes and is inspired from - #51246 and #50916

Testing Instructions

Open the WordPress block editor
Open the Preferences modal and check the colour value using Inspect Element.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2025-08-22 at 8 06 43 PM Screenshot 2025-08-22 at 8 07 01 PM

@kushagra-goyal-14 kushagra-goyal-14 marked this pull request as ready for review August 22, 2025 14:53
@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kushagra-goyal-14 <kush123@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ghorivipul97 <ghorivipul97@git.wordpress.org>
Co-authored-by: falgunihdesai <falgunihdesai@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended label Aug 23, 2025
@t-hamano t-hamano added the [Package] Components /packages/components label Aug 23, 2025
juanfra
juanfra requested changes Aug 23, 2025
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this ✨

Looks good overall! I noticed that the h2 and h3 elements inside the modal aren’t picking up the correct color. I’m wondering if it might make sense to target the .components-modal__frame class to set the text color there, and also explicitly style h1, h2, and h3 within it to override the defaults coming from the common CSS.

modal-colors.mp4

@kushagra-goyal-14
Copy link
Contributor Author

kushagra-goyal-14 commented Aug 28, 2025 •
edited
Loading

@juanfra I have updated the changes to target the .components-modal__frame class to set the text color there 🙌

@Mamaduka
Copy link
Member

Mamaduka commented Aug 29, 2025

@kushagra-goyal-14, could you rebase this branch on top of the latest trunk. That should resolve CI checks.

@juanfra
Copy link
Member

juanfra commented Aug 29, 2025

Thanks for working on this @kushagra-goyal-14! The code changes look good. Not sure if the comment before the color is a bit redundant.

Can you please be sure you sync trunk and rebase with the latest changes to fix the CI checks?

@juanfra
Copy link
Member

juanfra commented Sep 3, 2025

Thank you for updating the PR @kushagra-goyal-14 :)

Can you please update the changelog and move the readme entry to a ### Bug Fixes section under Unreleased? Thanks 🙌

@kushagra-goyal-14
Copy link
Contributor Author

kushagra-goyal-14 commented Sep 4, 2025 •
edited
Loading

Hello @juanfra,
I have added the entry under ### Bug Fixes in ## Unreleased but the test case still fails

juanfra
juanfra reviewed Sep 4, 2025
View reviewed changes
juanfra
juanfra approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Thank you!

@juanfra juanfra merged commit 60986cd into WordPress:trunk Sep 4, 2025
72 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 4, 2025
This was referenced Sep 4, 2025
Closed
Closed
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanfra juanfra juanfra approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 21.7

Development

Successfully merging this pull request may close these issues.

Modal headings and labels missing editor text color

4 participants

@kushagra-goyal-14 @Mamaduka @juanfra @t-hamano