Skip to content

Block comments: Add comment indicators in the block toolbar #71271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Sep 16, 2025
Merged

Block comments: Add comment indicators in the block toolbar #71271

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
e34c8c2
Collab Sidebar: Replace AddCommentToolbarButton with CommentAvatarInd…
yashjawale Aug 20, 2025
1f2a1db
refactor: use threadParticipants and enhance avatar styling for origi…
yashjawale Aug 20, 2025
73400a9
refactor: simplify comment avatar styling and improve background colo…
yashjawale Aug 20, 2025
d8cf981
refactor: update comment avatar styles to use border colors instead o…
yashjawale Aug 21, 2025
2e82c39
refactor: update comment resolution logic and simplify unresolved cou…
yashjawale Aug 21, 2025
2520dfd
refactor: filter out trashed comments in thread participant retrieval
yashjawale Aug 21, 2025
b286b3f
fix: handle case of 100+ comments
yashjawale Aug 29, 2025
58e11a8
refactor: update method for retrieving total pages of comments
yashjawale Aug 29, 2025
db5c16c
fix: style overflow indicator for longer text
yashjawale Aug 29, 2025
d9bf2ae
fix: sentence comments end with period
yashjawale Aug 29, 2025
d46bbae
fix: handle case where main comment is not found in thread
yashjawale Aug 29, 2025
e9cc58e
refactor: remove unused AddCommentToolbarButton component
yashjawale Aug 29, 2025
970dda7
fix: remove title attribute from avatar
yashjawale Sep 11, 2025
ff766e4
fix: overflowText i18n
yashjawale Sep 11, 2025
9f5f11a
fix: overflowTitle i18n
yashjawale Sep 11, 2025
237d7aa
fix: use SCSS variables in styles
yashjawale Sep 11, 2025
0425317
fix: remove unused `all-resolved` class
yashjawale Sep 11, 2025
b9defa9
fix: comment-indicator-toolbar.js syntax
yashjawale Sep 11, 2025
342f655
style: fix style.scss formatting
yashjawale Sep 11, 2025
24edb96
refactor: style.scss use base variables
yashjawale Sep 12, 2025
43bb5a3
refactor: optimize comment thread handling in CollabSidebar
yashjawale Sep 12, 2025
22ab72b
Merge branch 'trunk' into feat/comment-toolbar-indicator
yashjawale Sep 12, 2025
b33eb7b
fix: comment 100+ indicator
yashjawale Sep 12, 2025
0f4d335
fix: unused postStatus variable
yashjawale Sep 12, 2025
65ea1fd
fix: irregular hover background on indicator
yashjawale Sep 12, 2025
c11a5c8
refactor: simplify post and comment data retrieval in CollabSidebar u…
yashjawale Sep 12, 2025
71df444
fix: exclude trashed block comments from query
yashjawale Sep 12, 2025
089d6fb
fix: allow multiple comment statuses in REST API requests and simplif…
yashjawale Sep 15, 2025
7d42184
fix: EOL whitespace in block-comments.php
yashjawale Sep 15, 2025
97877fd
Merge branch 'trunk' into feat/comment-toolbar-indicator
yashjawale Sep 15, 2025
7b86a9a
fix: remove function_exists check for gutenberg_filter_rest_comment_c…
yashjawale Sep 15, 2025
e48d5ad
fix: remove memoization from query arguments
yashjawale Sep 15, 2025
d42b3c4
Merge branch 'trunk' into feat/comment-toolbar-indicator
yashjawale Sep 15, 2025
6bff632
Merge branch 'trunk' into feat/comment-toolbar-indicator
yashjawale Sep 15, 2025
781e4d6
Refactor: Remove support for multiple comment statuses in REST API re…
yashjawale Sep 15, 2025
88f1954
Update packages/editor/src/components/collab-sidebar/comment-indicato…
t-hamano Sep 16, 2025
c2080f1
Update packages/editor/src/components/collab-sidebar/comment-indicato…
t-hamano Sep 16, 2025
a8acf34
Update packages/editor/src/components/collab-sidebar/comment-indicato…
t-hamano Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove unused all-resolved class 
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
  • Loading branch information
@yashjawale @t-hamano
yashjawale and t-hamano authored Sep 11, 2025
commit 04253177cc99f3dd0381d477744db43e9f92c383
6 changes: 3 additions & 3 deletions packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@

// If we hit the comment limit, show "100+" instead of exact overflow count.
const overflowText =
const overflowText =

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Check 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Build Release Artifact 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Run performance tests 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / check 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 1 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 8 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 4 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 7 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 3 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 5 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 2 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Playwright - 6 

Expression expected.

Check failure on line 142 in packages/editor/src/components/collab-sidebar/comment-indicator-toolbar.js

View workflow job for this annotation

GitHub Actions / Build JavaScript assets for PHP unit tests 

Expression expected.
hasMoreComments && overflowCount > 0
? __( '100+' )
: sprintf(
Expand All @@ -160,9 +160,9 @@
return (
<CommentIconToolbarSlotFill.Fill>
<ToolbarButton
className={ `comment-avatar-indicator ${
hasUnresolved ? 'has-unresolved' : 'all-resolved'
}` }
className={ clsx( 'comment-avatar-indicator', {
'has-unresolved': hasUnresolved,
} ) }
label={ _x( 'View comments', 'View comment thread' ) }
onClick={ onClick }
showTooltip
Expand Down
Loading