Skip to content

Add support for precision type placeholders to translator comments eslint #71145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Add support for precision type placeholders to translator comments eslint #71145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d699b4
feat: add precision based placeholder supports to translators
USERSATOSHI Aug 8, 2025
e10b175
refactor: remove commented debug logs from i18n-translator-comments.js
USERSATOSHI Aug 8, 2025
4c72be9
tests: remove extra comments
USERSATOSHI Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove commented debug logs from i18n-translator-comments.js
  • Loading branch information
@USERSATOSHI
USERSATOSHI committed Aug 8, 2025
commit e10b175e5c123daf7ccafd0b0208edc225c81d21
3 changes: 0 additions & 3 deletions packages/eslint-plugin/rules/i18n-translator-comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ module.exports = {
extractTranslatorKeys( commentText );
const placeholdersUsed =
candidates.flatMap( extractPlaceholders );
// console.log( { keysInComment, placeholdersUsed } );

const keysInCommentArr = [ ...keysInComment.keys() ];

Expand Down Expand Up @@ -214,8 +213,6 @@ module.exports = {
} )
: [];

// console.log({extra, keysInComment, placeholdersUsed});

if ( extra.length > 0 ) {
context.report( {
node,
Expand Down
Loading