Repository navigation
Gallery: Fix caption updates not reflecting when using Edit Gallery interface - #71142
Open
snehapatil2001 wants to merge 1 commit into
Open
snehapatil2001 wants to merge 1 commit into
snehapatil2001 wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Thanks for contributing, @snehapatil2001! Unfortunately, I don't think this is actionable at the moment. I've shared some of the reasons in the issue - #71131 (comment). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71131
Fix Gallery block caption updates not reflecting when using the "Edit Gallery" interface in the Media Library.
Why?
When users edit a gallery and update image captions through the "Edit Gallery" interface in the Media Library, the changes were not being reflected in the gallery block. The issue occurred because the
updateImagesfunction was reusing existing image blocks without applying the updated attributes from the Media Library, causing caption changes to be lost.How?
Modified the
updateImagesfunction inpackages/block-library/src/gallery/edit.jsto:buildImageAttributes().createBlock()to create new blocks with updated attributes while maintaining the existing block structure.buildImageAttributeshelper function.The key change is in the
updatedExistingBlockslogic where we now:buildImageAttributes()to merge the updated media data with gallery settingsTesting Instructions
Testing Instructions for Keyboard
Before:
Screen.Recording.2025-08-10.at.8.51.26.AM.mov
After
Screen.Recording.2025-08-08.at.6.21.45.PM.mov