Add aspect ratio control for gallery block#71116
Merged
scruffian merged 8 commits intoWordPress:feat/aspect-ratio-for-gallery-blockfrom Oct 6, 2025
Merged
Conversation
dhananjaykuber
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Enhancement
mtias
added
[Block] Gallery
Member
|
Thanks for working on this! |
mtias
added
the
[Feature] Design Tools
|
thank you! this is so critical! clients upload a million diff image ratios and expect multiple galleries to all look the same! |
Contributor
|
This is working great in my testing. Pinging @t-hamano also. |
tyxla
reviewed
Sep 16, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looks like some tests should be updated with the new block.json attributes
t-hamano
reviewed
Sep 16, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the ping! I don't have time to actually test it right now, but I'll take a look at the code and leave feedback on anything that bothers me.
Contributor
|
@dhananjaykuber are you able to followup with these fixes? |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
scruffian
reviewed
Oct 6, 2025
scruffian
approved these changes
Oct 6, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
I think this is ready to bring in now. Might be good to get a review from someone else.
scruffian
reviewed
Oct 6, 2025
Contributor
|
This PR also needs the fixtures regenerating. I think the best way forward here might be to merge this into a different branch in Gutenberg and keep iterating there, so I can update it. |
scruffian
changed the base branch from
trunk
to
feat/aspect-ratio-for-gallery-block
scruffian
merged commit a2129d6
into
WordPress:feat/aspect-ratio-for-gallery-block
63 of 67 checks passed
scruffian
added a commit
that referenced
this pull request
Oct 7, 2025
* Add aspect ratio control for gallery block (#71116) Merging into a branch in the main repo so I can fix the tests. * feat: Add aspect ratio control for gallery block * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Apply suggestion from @scruffian * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update packages/block-library/src/gallery/edit.js * Update packages/block-library/src/gallery/edit.js * Apply suggestion from @scruffian --------- Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jhmonroe <jhmonroe@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> * update fixtures * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Dhananjay Kuber <dhananjay.kuber@rtcamp.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jhmonroe <jhmonroe@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org>
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…ss#72104) * Add aspect ratio control for gallery block (WordPress#71116) Merging into a branch in the main repo so I can fix the tests. * feat: Add aspect ratio control for gallery block * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Apply suggestion from @scruffian * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update packages/block-library/src/gallery/edit.js * Update packages/block-library/src/gallery/edit.js * Apply suggestion from @scruffian --------- Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jhmonroe <jhmonroe@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> * update fixtures * Update packages/block-library/src/gallery/edit.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Dhananjay Kuber <dhananjay.kuber@rtcamp.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jhmonroe <jhmonroe@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66760
What?
Adds aspect ratio control to the Gallery block, allowing users to force all image blocks within the gallery to use the same aspect ratio for consistent visual presentation.
Why?
Currently the Gallery block displays images in their original aspect ratios, there is no way to control their aspect ratio.
How?
Add Aspect Ration control for gallery block.
Testing Instructions
Screenshots or screencast