Skip to content

Handle label fallback for dropdownMenu#70951

Merged
mirka merged 3 commits intoWordPress:trunkfrom
im3dabasia:try/dropdownMenuProps-label-fix
Nov 2, 2025
Merged

Handle label fallback for dropdownMenu#70951
mirka merged 3 commits intoWordPress:trunkfrom
im3dabasia:try/dropdownMenuProps-label-fix

Conversation

@im3dabasia
Copy link
Copy Markdown
Contributor

@im3dabasia im3dabasia commented Jul 29, 2025 •
edited
Loading

Closes: #70949

What?

Omitted label prop from the dropdownMenuProps used inside ToolsPanelHeaderProps

@im3dabasia im3dabasia changed the title [WIP]: Handle label fallback for dropdownMenu Handle label fallback for dropdownMenu Jul 30, 2025
@im3dabasia im3dabasia marked this pull request as ready for review July 30, 2025 05:57
@im3dabasia im3dabasia requested a review from ajitbohra as a code owner July 30, 2025 05:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 30, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Jul 31, 2025
@t-hamano
Copy link
Copy Markdown
Contributor

t-hamano commented Jul 31, 2025

@im3dabasia Thanks for the PR!

Can you update this PR according to this comment?

@t-hamano t-hamano requested a review from a team July 31, 2025 01:01
t-hamano
t-hamano reviewed Aug 6, 2025
View reviewed changes
packages/components/src/tools-panel/types.ts
Comment on lines -80 to +83
dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;
dropdownMenuProps?: Omit<
React.ComponentProps< typeof DropdownMenu >,
'label'
>;
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this format is correct, but I don't know how to describe it in the README 😅

gutenberg/packages/components/src/tools-panel/tools-panel-header/README.md

Line 25 in 53b643c

- Type: `DropdownMenuProps`

cc @WordPress/gutenberg-components

Additionally, I think we need to update here as well:

gutenberg/packages/components/src/tools-panel/types.ts

Line 23 in 53b643c

dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;

Copy link
Copy Markdown
Member

@mirka mirka Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to describe it in the README 😅

Mm, I'm fine with this for now, it's not crucial information. And we won't have to think about this once these are converted to an autogenerated readme!

mirka
mirka approved these changes Nov 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is good to go? Sorry for the delay!

@mirka mirka merged commit b754e9f into WordPress:trunk Nov 2, 2025
41 of 43 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 2, 2025
@t-hamano t-hamano mentioned this pull request Feb 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano left review comments

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 22.1

Development

Successfully merging this pull request may close these issues.

ToolsPanel: dropdownMenuProps type requires unnecessary label property

3 participants

@im3dabasia @t-hamano @mirka