Skip to content

Page List: Fix Notice component background gets incorrectly inherited #70932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Page List: Fix Notice component background gets incorrectly inherited #70932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove unnecessary styles
  • Loading branch information
@yogeshbhutkar
yogeshbhutkar committed Jul 28, 2025
commit 7186e25cfdf895096f0b0d9d06a21e5cae505533
6 changes: 0 additions & 6 deletions packages/block-library/src/page-list/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
.wp-block-navigation {
// Block wrapper gets the classes in the editor, and there's an extra div wrapper for now, so background styles need to be inherited.
.wp-block-page-list > div,
.wp-block-page-list {
background-color: inherit;
Comment on lines -4 to -5
Copy link
Contributor Author

@yogeshbhutkar yogeshbhutkar Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .wp-block-page-list rule was also removed as it appeared redundant, as it's also defined within the corresponding style.scss file.

See:

gutenberg/packages/block-library/src/page-list/style.scss

Line 9 in 094eb82

background-color: inherit;

}

// space-between justification.
&.items-justified-space-between {
.wp-block-page-list > div,
Expand Down
Loading