Migrate element package to TS #70886
Conversation
t-hamano
added
[Type] Code Quality
dhruvikpatel18
force-pushed
the
try/convert-element-ts
branch
from
a73cef7 to
d7724d7
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
This looks pretty good. Thank you.
I just have some suggestions about cleaning up JSDoc types
dhruvikpatel18
force-pushed
the
try/convert-element-ts
branch
from
d7724d7 to
21e3164
Compare
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
There are still many more non-null assertions left in this PR. Let us remove them all.
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
This looks pretty good now.
I would like @jsnajdr @tyxla @sirreal or @youknowriad to have a second look.
|
Once this gets shipped, I have some interesting changes in mind for |
|
Let us resolve the conflicts here after updating the branch from trunk. |
|
Can we please update this branch from trunk? |
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
Let us update this from trunk
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
This looks good now. Thank you for making the suggested changes.
3 participants
What?
Part of: #67691
Migrating the element package to Typescript.
Why?
Type safety.
Testing Instructions
Type check