Skip to content

Query Loop Block: Fix broken placeholder #70840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 27, 2025
Merged

Query Loop Block: Fix broken placeholder #70840

merged 9 commits into from
Aug 27, 2025

Conversation

@vipul0425
Copy link
Contributor

@vipul0425 vipul0425 commented Jul 22, 2025

What?

Part of #64288

Why?

For compact containers the placeholder of query block looks broken.

How?

This PR follows the design provided in #64288 to fix the issue for Query Block. It adds the block controls to choose patterns and an observer to change the placeholder content if used in compact containers.

Testing Instructions

  1. Add a columns block or grid block. Choose 6+ columns or grid in a row and add a Query loop block.
  2. Now check the placeholder, also there will be block controls on placeholder as well.

Screenshots or screencast

Screen.Recording.2025-07-22.at.5.14.34.PM.mov

@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@vipul0425 vipul0425 mentioned this pull request Jul 22, 2025
Open
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Jul 22, 2025
@t-hamano t-hamano changed the title [Type] Enhancement - Fix broken placeholder issue for query block. Query Loop Block: Fix broken placeholder Jul 23, 2025
@jasmussen jasmussen self-requested a review August 4, 2025 10:50
jasmussen
jasmussen approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a pure behavioral perspective, this is a move in the right direction, and good to go:
loop

Here's the trunk behavior:
before

Noting that while the trunk behavior barely works in the above, there are also translations to worry about, which is why the new approach is better.

This could use a code review.

t-hamano
t-hamano reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I've left some feedback, but it almost looks good!

@vipul0425 vipul0425 requested a review from t-hamano August 27, 2025 05:49
@vipul0425
Copy link
Contributor Author

vipul0425 commented Aug 27, 2025

Thanks @t-hamano 🙇. I have updated the PR.

t-hamano
t-hamano reviewed Aug 27, 2025
View reviewed changes
@vipul0425 vipul0425 requested a review from t-hamano August 27, 2025 07:39
t-hamano
t-hamano approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for your work!

@t-hamano t-hamano merged commit 78b1abb into WordPress:trunk Aug 27, 2025
88 of 106 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.6 milestone Aug 27, 2025
@maxschmeling maxschmeling mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasmussen jasmussen jasmussen approved these changes

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 21.6

Development

Successfully merging this pull request may close these issues.

3 participants

@vipul0425 @jasmussen @t-hamano