Skip to content

TypeScript: migrate server-side-render package to TS#70755

Closed
kushagra-goyal-14 wants to merge 4 commits intoWordPress:trunkfrom
kushagra-goyal-14:try/migrate-server-side-render-ts
Closed

TypeScript: migrate server-side-render package to TS#70755
kushagra-goyal-14 wants to merge 4 commits intoWordPress:trunkfrom
kushagra-goyal-14:try/migrate-server-side-render-ts

Conversation

@kushagra-goyal-14
Copy link
Copy Markdown
Contributor

What?

Part of #67691

Migrating the server-side-render package to TypeScript.

Why?

To enhance DX and add type safety.

How?

By porting the code and tests to TypeScript.

Testing Instructions

Typecheck and unit tests.

@kushagra-goyal-14
Copy link
Copy Markdown
Contributor Author

It seems that the test case for (Unit Tests / Mobile) is failing, most likely because the TypeScript code hasn't been compiled yet, and the functions are being called with the same names — as also mentioned in this comment.

Since this package contains logic for server-side-render, it ideally should be compiled to JavaScript before usage.

Could you please guide me on the best way to proceed with ensuring the TypeScript compilation is handled properly here?

cc: @t-hamano , @manzoorwanijk

@kushagra-goyal-14 kushagra-goyal-14 marked this pull request as ready for review July 17, 2025 12:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 17, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kushagra-goyal-14 <kush123@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Server Side Render /packages/server-side-render labels Jul 17, 2025
@Mamaduka
Copy link
Copy Markdown
Member

Let's put this on hold for now. I'm planning to merge some major changes for SSR #70543.

@Mamaduka Mamaduka added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Jul 18, 2025
@Mamaduka
Copy link
Copy Markdown
Member

#70543 is now merged. Though I think it might be easier to start with a fresh PR for a migration now. The merge conflicts can be annoying to resolve.

Sorry about that, @kushagra-goyal-14!

@kushagra-goyal-14
Copy link
Copy Markdown
Contributor Author

#70543 is now merged. Though I think it might be easier to start with a fresh PR for a migration now. The merge conflicts can be annoying to resolve.

Sorry about that, @kushagra-goyal-14!

No issues, i will create a new PR

@Mamaduka
Copy link
Copy Markdown
Member

@kushagra-goyal-14, I'm going to close this, since you mentioned creating a new PR.

Thanks again for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Server Side Render /packages/server-side-render [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants