TypeScript: migrate server-side-render package to TS#70755
TypeScript: migrate server-side-render package to TS#70755kushagra-goyal-14 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
…sx for type re-exports
|
It seems that the test case for (Unit Tests / Mobile) is failing, most likely because the TypeScript code hasn't been compiled yet, and the functions are being called with the same names — as also mentioned in this comment. Since this package contains logic for server-side-render, it ideally should be compiled to JavaScript before usage. Could you please guide me on the best way to proceed with ensuring the TypeScript compilation is handled properly here? cc: @t-hamano , @manzoorwanijk |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Let's put this on hold for now. I'm planning to merge some major changes for SSR #70543. |
|
#70543 is now merged. Though I think it might be easier to start with a fresh PR for a migration now. The merge conflicts can be annoying to resolve. Sorry about that, @kushagra-goyal-14! |
No issues, i will create a new PR |
|
@kushagra-goyal-14, I'm going to close this, since you mentioned creating a new PR. Thanks again for working on this. |
What?
Part of #67691
Migrating the server-side-render package to TypeScript.
Why?
To enhance DX and add type safety.
How?
By porting the code and tests to TypeScript.
Testing Instructions
Typecheck and unit tests.